Add all IdPs to the export when ACL allowAll=true #672
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MKodde
commented
Aug 22, 2024
| @@ -42,7 +42,7 @@ | |||
| "_id": "0c3febd2-3f67-4b8a-b90d-ce56a3b0abb6", | |||
| "version": 0, | |||
| "data": { | |||
| "entityid": "https://engine.dev.support.surfconext.nl/authentication/idp/metadata2", | |||
| "entityid": "https://engine.dev.support.surfconext.nl/authentication/idp/metadata3", | |||
There was a problem hiding this comment.
This would not be possible in Manage, have two entities with the same entityId, fixed that in test
🌲
It makes sense to show all connected IdP's in the CSV export for the surfconext representative. When the ACL is set to allow all IdPs connected to the SP, we should list all IdPs of the test env there. This can be a long list. But now we would only show the Organizations IdPs, and the explicitly marked test-idps. See: https://www.pivotaltracker.com/story/show/187805216/comments/242257758
MKodde
force-pushed
the
feature/add-allow-all-idps-to-export
branch
from
df10cc4
to
e0c29f5
Compare
johanib
approved these changes
Aug 22, 2024
|
@quartje and @teunfransen will ensure this feature is tested for functional correctness |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It makes sense to show all connected IdP's in the CSV export for the surfconext representative. When the ACL is set to allow all IdPs connected to the SP, we should list all IdPs of the test env there.
This can be a long list. But now we would only show the Organizations IdPs, and the explicitly marked test-idps.
See: https://www.pivotaltracker.com/story/show/187805216/comments/242257758