Introduce a branch_version concept in BCI #1830
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Created a staging project on OBS for 5: home:defolos:BCI:Staging:SLE-15-SP5:5-1830 |
|
Created a staging project on OBS for 7: home:defolos:BCI:Staging:SLE-15-SP7:7-1830 Build ResultsRepository
Repository
Repository
Repository
Repository
Repository
Repository
Repository
Build failed ❌ To run BCI-tests against this PR, use the following command: OS_VERSION=15.7 TARGET=custom BASEURL=registry.opensuse.org/home/defolos/bci/staging/sle-15-sp7/7-1830/ tox -- -n autoThe following images can be pulled from the staging project:
|
|
Created a staging project on OBS for Tumbleweed: home:defolos:BCI:Staging:Tumbleweed:Tumbleweed-1830 Build ResultsRepository
Repository
Repository
Repository
Build succeeded ✅ To run BCI-tests against this PR, use the following command: OS_VERSION=tumbleweed TARGET=custom BASEURL=registry.opensuse.org/home/defolos/bci/staging/tumbleweed/tumbleweed-1830/ tox -- -n autoThe following images can be pulled from the staging project:
|
|
Created a staging project on OBS for 6: home:defolos:BCI:Staging:SLE-15-SP6:6-1830 Build ResultsRepository
Repository
Repository
Repository
Repository
Repository
Repository
Repository
Build failed ❌ To run BCI-tests against this PR, use the following command: OS_VERSION=15.6 TARGET=custom BASEURL=registry.opensuse.org/home/defolos/bci/staging/sle-15-sp6/6-1830/ tox -- -n autoThe following images can be pulled from the staging project:
|
dirkmueller
force-pushed
the
branch_version
branch
from
b194f1a
to
36b84fd
Compare
dirkmueller
force-pushed
the
branch_version
branch
2 times, most recently
from
5a4cbeb
to
57a54bf
Compare
dirkmueller
force-pushed
the
branch_version
branch
from
57a54bf
to
e3737f9
Compare
|
(ready for review but since I added tests it will require a rebase again once #1828 is merged) |
dirkmueller
force-pushed
the
branch_version
branch
from
e3737f9
to
cc51e71
Compare
dirkmueller
force-pushed
the
branch_version
branch
from
cc51e71
to
6a922a9
Compare
dirkmueller
force-pushed
the
branch_version
branch
from
6a922a9
to
77a78df
Compare
dirkmueller
force-pushed
the
branch_version
branch
from
77a78df
to
cce5677
Compare
dirkmueller
force-pushed
the
branch_version
branch
from
cce5677
to
d0973ac
Compare
Now that we have build_flavors, we can add branch_versions, describing
the full hierachy:
Each container can have a single `name`, one or many `branch_versions`
and each of them one or many `build_flavors`.
this means our naming should become
{name}-{branch_version}-{build_flavor}
Introduce this for the AppCollection containers first. This should
eventually replace tag_version, which is a broken concept as it
mixes namings, versions and flavors into and hence makes everything
convoluted.
This commit mixes also a hook in Registry to use version, rather than
tag_version for the build_version, which is a must-have for the
AppCollection integration.
Add tests for ApplicationStackContainers in unit test, which was
entirely untested so far.
Removal of the deprecated tag_version will happen in a later followup.
dirkmueller
force-pushed
the
branch_version
branch
from
d0973ac
to
2762bf3
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now that we have build_flavors, we can add branch_versions, describing the full hierachy:
Each container can have a single
name, one or manybranch_versionsand each of them one or manybuild_flavors.this means our naming should become
{name}-{branch_version}-{build_flavor}
Introduce this for the AppCollection containers first. This should eventually replace tag_version, which is a broken concept as it mixes namings, versions and flavors into and hence makes everything convoluted.
This commit mixes also a hook in Registry to use version, rather than tag_version for the build_version, which is a must-have for the AppCollection integration.
Removal of the deprecated tag_version will happen in a later followup.