-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Build the base containers with the docker-flavor #508
Conversation
Created a staging project on OBS for Tumbleweed: home:defolos:BCI:Staging:Tumbleweed:Tumbleweed-FBITQ Build ResultsRepository
Repository
Repository
Repository
Build succeeded ✅ |
Created a staging project on OBS for 4: home:defolos:BCI:Staging:SLE-15-SP4:sle15-sp4-CTdhb Build ResultsRepository
Repository
Repository
Repository
Repository
Repository
Repository
Repository
Build succeeded ✅ |
Created a staging project on OBS for 5: home:defolos:BCI:Staging:SLE-15-SP5:sle15-sp5-vCuFv Build ResultsRepository
Repository
Repository
Repository
Repository
Repository
Repository
Repository
Build succeeded ✅ |
e9bd1d4
to
353bea9
Compare
Created a staging project on OBS for 4: home:defolos:BCI:Staging:SLE-15-SP4:sle15-sp4-CMkby |
Created a staging project on OBS for Tumbleweed: home:defolos:BCI:Staging:Tumbleweed:Tumbleweed-EELDy Build ResultsRepository
Repository
Repository
Repository
Build succeeded ✅ |
Created a staging project on OBS for 5: home:defolos:BCI:Staging:SLE-15-SP5:sle15-sp5-xZRbY Build ResultsRepository
Repository
Repository
Repository
Repository
Repository
Repository
Repository
Build succeeded ✅ |
src/bci_build/package.py
Outdated
# Ensure that we build base OS containers with the proper product flavor | ||
# for correct telemetry reporting | ||
if self.is_opensuse and isinstance(self, OsContainer): | ||
bootstrap_packages.append("openSUSE-release-appliance-docker") | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No, please no additional hidden magic. I fear that this will be impossible to find down the road why packages are suddenly getting added in some containers and not in others.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
well, in this case it is easy to grep (just search for the package name)
353bea9
to
ad499a5
Compare
Created a staging project on OBS for 5: home:defolos:BCI:Staging:SLE-15-SP5:sle15-sp5-pxfDG Build ResultsRepository
Repository
Repository
Repository
Repository
Repository
Repository
Repository
Build succeeded ✅ |
Created a staging project on OBS for 4: home:defolos:BCI:Staging:SLE-15-SP4:sle15-sp4-RlULl Build ResultsRepository
Repository
Repository
Repository
Repository
Repository
Repository
Repository
Build succeeded ✅ |
Created a staging project on OBS for Tumbleweed: home:defolos:BCI:Staging:Tumbleweed:Tumbleweed-DwLno Build ResultsRepository
Repository
Repository
Repository
Build succeeded ✅ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, but needs a rebase.
Created a staging project on OBS for 4: home:defolos:BCI:Staging:SLE-15-SP4:sle15-sp4-zJtnj Build ResultsRepository
Repository
Repository
Repository
Repository
Repository
Repository
Repository
Build succeeded ✅ |
Created a staging project on OBS for 5: home:defolos:BCI:Staging:SLE-15-SP5:sle15-sp5-auvgP Build ResultsRepository
Repository
Repository
Repository
Repository
Repository
Repository
Repository
Build succeeded ✅ |
Created a staging project on OBS for 4: home:defolos:BCI:Staging:SLE-15-SP4:sle15-sp4-ZQElB Build ResultsRepository
Repository
Repository
Repository
Repository
Repository
Repository
Repository
Build succeeded ✅ |
Created a staging project on OBS for Tumbleweed: home:defolos:BCI:Staging:Tumbleweed:Tumbleweed-LCwcT Build ResultsRepository
Repository
Repository
Repository
Build failed ❌ |
Created a staging project on OBS for 5: home:defolos:BCI:Staging:SLE-15-SP5:sle15-sp5-MzDHA Build ResultsRepository
Repository
Repository
Repository
Repository
Repository
Repository
Repository
Build succeeded ✅ |
feb090a
to
1863086
Compare
Created a staging project on OBS for 4: home:defolos:BCI:Staging:SLE-15-SP4:sle15-sp4-YIWac Build ResultsRepository
Repository
Repository
Repository
Repository
Repository
Repository
Repository
Build succeeded ✅ |
Created a staging project on OBS for Tumbleweed: home:defolos:BCI:Staging:Tumbleweed:Tumbleweed-XwOXJ Build ResultsRepository
Repository
Repository
Repository
Build succeeded ✅ |
Created a staging project on OBS for 5: home:defolos:BCI:Staging:SLE-15-SP5:sle15-sp5-CHBla Build ResultsRepository
Repository
Repository
Repository
Repository
Repository
Repository
Repository
Build succeeded ✅ |
Created a staging project on OBS for 4: home:defolos:BCI:Staging:SLE-15-SP4:sle15-sp4-pqOpq Build ResultsRepository
Repository
Repository
Repository
Repository
Repository
Repository
Repository
Build succeeded ✅ |
Created a staging project on OBS for Tumbleweed: home:defolos:BCI:Staging:Tumbleweed:Tumbleweed-ejVZL Build ResultsRepository
Repository
Repository
Repository
Build succeeded ✅ |
Created a staging project on OBS for 5: home:defolos:BCI:Staging:SLE-15-SP5:sle15-sp5-dIAGk Build ResultsRepository
Repository
Repository
Repository
Repository
Repository
Repository
Repository
Build succeeded ✅ |
Otherwise the ftp flavor is used, which is incorrect
Co-authored-by: Dan Čermák <[email protected]>
The languagestack shouldn't need those as the base containers already include them.
b00ab41
to
05fd9b6
Compare
Created a staging project on OBS for 4: home:defolos:BCI:Staging:SLE-15-SP4:sle15-sp4-zrraG Build ResultsRepository
Repository
Repository
Repository
Repository
Repository
Repository
Repository
Build succeeded ✅ |
Created a staging project on OBS for Tumbleweed: home:defolos:BCI:Staging:Tumbleweed:Tumbleweed-cCSSV Build ResultsRepository
Repository
Repository
Repository
Build succeeded ✅ |
Created a staging project on OBS for 5: home:defolos:BCI:Staging:SLE-15-SP5:sle15-sp5-NlqaA Build ResultsRepository
Repository
Repository
Repository
Repository
Repository
Repository
Repository
Build succeeded ✅ |
Otherwise the ftp flavor is used, which is incorrect