Remove 3.10, add 3.12 #444
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dcermak
reviewed
Apr 10, 2024
dcermak
previously approved these changes
Apr 10, 2024
we first need to convert the tox runs to use python 3.12 instead of 3.10 before merging this |
dirkmueller
force-pushed
the
py312
branch
4 times, most recently
from
4fbc66b
to
b6de9db
Compare
Ubuntu 22.04 is the only one with 3.10, we replace that with 24.04 which uses 3.12
dcermak
reviewed
Jun 17, 2024
| @@ -17,6 +19,7 @@ deps = | |||
| doc: Sphinx | |||
|
|
|||
| [testenv] | |||
| basepython = python3.11 | |||
There was a problem hiding this comment.
Any particular reason why you are hardcoding the tests to use python 3.11? That will cause a giant headache for QA, who are using the system python in openQA.
There was a problem hiding this comment.
this is still a draft, I'm trying to find a workable path forward to get it to not use the system python. however, for SLE15 I don't see a problem with requiring python311 for the QA team. it might be more difficult for the tests on non-SLE hosts, but one problem at a time.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ubuntu 22.04 is the only one with 3.10, we replace that with 24.04 which uses 3.12