Skip to content

Commit

Permalink
monitoring: put node_exporter ARGS all on one line (bsc#1188486)
Browse files Browse the repository at this point in the history
There's a problem in /bin/fillup, where it sometimes doesn't parse
multiline strings properly in sysconfig files.  This results in
corruption of /etc/sysconfig/prometheus-node_exporter when the
golang-github-prometheus-node_exporter package is updated.  We can
work around this by putting all the arguments on one line.  See
https://bugzilla.opensuse.org/show_bug.cgi?id=1153280 and
openSUSE/fillup#1 for the underyling
issue.

Fixes: https://bugzilla.suse.com/show_bug.cgi?id=1188486
Signed-off-by: Tim Serong <[email protected]>
  • Loading branch information
tserong authored and Hypertrophik committed Jul 28, 2021
1 parent 325002f commit 98fcc90
Showing 1 changed file with 1 addition and 4 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -29,10 +29,7 @@ set node exporter service args:
- name: /etc/sysconfig/prometheus-node_exporter
- mode: 644
- contents: |
ARGS="--collector.diskstats.ignored-devices=^(ram|loop|fd)\d+$ \
--collector.filesystem.ignored-mount-points=^/(sys|proc|dev|run)($|/) \
--collector.textfile.directory=/var/lib/prometheus/node-exporter \
--collector.bonding --collector.ntp"
ARGS="--collector.diskstats.ignored-devices=^(ram|loop|fd)\d+$ --collector.filesystem.ignored-mount-points=^/(sys|proc|dev|run)($|/) --collector.textfile.directory=/var/lib/prometheus/node-exporter --collector.bonding --collector.ntp"
{% if grains.get('os', '') == 'CentOS' %}

Expand Down

0 comments on commit 98fcc90

Please sign in to comment.