Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update factory_bot 6.2.1 → 6.4.1 (minor) #1399

Closed
wants to merge 1 commit into from

Conversation

depfu[bot]
Copy link
Contributor

@depfu depfu bot commented Nov 21, 2023

Here is everything you need to know about this update. Please take a good look at what changed and the test results before merging this pull request.

What changed?

↗️ factory_bot (indirect, 6.2.1 → 6.4.1) · Repo · Changelog

Release Notes

6.4.1

  • Fix: factories with traits pass their class to ActiveSupport::Notifications
    (makicamel).

6.4.0

  • Added: if build_stubbed detects a UUID primary key, generate the correct type (Peter Boling, Alexandre Ruban).
  • Docs: show examples of Ruby 3 syntactic sugars (Sean Doyle).
  • Internal: resolve test warning messages (Mike Burns).

6.3.0

  • Fix: link to changelog for RubyGems (Berkan Ünal).
  • Fix: integrate with Ruby 3.2's did_you_mean library (Daniel Colson).
  • Changed: explicitly define #destroyed? within the Stub strategy to return false to be consistent
    with ActiveRecord (Benjamin Fleischer).
  • Added: announce factory_bot.compile_factory notification (Sean Doyle).
  • Docs: clarify that custom strategies need to define #to_sym (Edmund Korley, Jonas S).
  • Docs: fix CI link in README (Mark Huk).
  • Docs: fix GitHub links (Robert Fletcher).
  • Docs: install this library with bundle add (Glauco Custódio).
  • Docs: re-write into mdBook (Mike Burns, Sara Jackson, Stefanni Brasil)
  • Docs: clarify that automatic trait definitions could introduce new linting errors (Lawrence Chou).
  • Internal: skip TruffleRuby on Rails 5.0, 5.1, 5.2 (Andrii Konchyn).
  • Internal: fix typoes throughout codebase (Yudai Takada).
  • Internal: run CI on actions/checkout v3 (Yudai Takada).
  • Internal: follow standardrb code style (Yudai Takada).
  • Internal: stop using Hound (Daniel Nolan).
  • Internal: only run simplecov on C Ruby (Daniel Colson).
  • Internal: quieter Cucumber (Daniel Colson).
  • Internal: Ruby 3.2 support (Daniel Colson).
  • Internal: Mike Burns is the CODEOWNER (Stefanni Brasil).

New Contributors

Full diff: v6.2.1...v6.3.0

Does any of this look wrong? Please let us know.

Commits

See the full diff on Github. The new version differs by 31 commits:

✳️ factory_bot_rails (6.2.0 → 6.4.0) · Repo · Changelog

Release Notes

6.4.0 (from changelog)

  • Releasing this for consistency with the factory_bot dependency.

6.3.0

  • Changed: reject sequence definitions for ActiveRecord primary keys (Sean Doyle).
  • Changed: factory_bot dependency to ~> 6.4 (Mike Burns).
  • Changed: upgrade dependencies (Daniel Colson).
  • Add: projections.json for Rails.vim (Caleb Hearth).
  • Docs: fix broken link (Edu Depetris).
  • Docs: mention Rails generator in docs (Edu Depetris).
  • Docs: fix typo (Yudai Takada).
  • Internal: skip Spring version 2.1.1 due to a bug in that release (Christina
    Entcheva, Daniel Colson).
  • Internal: test against Rails 6.1 (Antonis Berkakis).
  • Internal: test against Ruby 3 (Daniel Colson).
  • Internal: fewer warnings in Cucumber tests (Daniel Colson).
  • Internal: use GitHub Actions for CI (Mathieu Jobin).
  • Internal: a whole bunch of cleanup (Daniel Colson).
  • Internal: fix CI due to a Bundler output change (Mike Burns).

Does any of this look wrong? Please let us know.

Commits

See the full diff on Github. The new version differs by 18 commits:


Depfu Status

Depfu will automatically keep this PR conflict-free, as long as you don't add any commits to this branch yourself. You can also trigger a rebase manually by commenting with @depfu rebase.

All Depfu comment commands
@​depfu rebase
Rebases against your default branch and redoes this update
@​depfu recreate
Recreates this PR, overwriting any edits that you've made to it
@​depfu merge
Merges this PR once your tests are passing and conflicts are resolved
@​depfu cancel merge
Cancels automatic merging of this PR
@​depfu close
Closes this PR and deletes the branch
@​depfu reopen
Restores the branch and reopens this PR (if it's closed)
@​depfu pause
Ignores all future updates for this dependency and closes this PR
@​depfu pause [minor|major]
Ignores all future minor/major updates for this dependency and closes this PR
@​depfu resume
Future versions of this dependency will create PRs again (leaves this PR as is)

@danidoni
Copy link
Contributor

danidoni commented Nov 22, 2023

This is failing due to a bug in factory_bot. Waiting for the fix1 to be merged.

Footnotes

  1. https://github.com/thoughtbot/factory_bot_rails/pull/432

Copy link
Contributor Author

depfu bot commented Nov 23, 2023

Closed in favor of #1403.

@depfu depfu bot closed this Nov 23, 2023
@depfu depfu bot deleted the depfu/update/factory_bot-6.4.1 branch November 23, 2023 15:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant