Changes for when swiftsimio merges SOAP support #110
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@JBorrow the changes to match changed names in swiftsimio should be merged now and a new release made. Waiting on this to release a new swiftgalaxy version. You might prefer to tweak the changes to installation, this was just the first solution that I hit on that didn't crash during install (on python3.12 on cosma, can try to reproduce details if needed). |
|
Sorry I just realised I may have merged too early. Let me know when this is ready to go. |
|
I'll create a new release at that time |
|
I think that it is done actually... if you could make a release that'd be grand. Not aware of any other issues for now, if I find anything I'll open a new PR. |
|
Sounds good, I guess it needs formatting too. |
|
Ah true. |
|
//pypi.org/project/velociraptor/0.18.0/ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The swiftsimio branch
load_fof_catalolguesintroduces some changes that break elements of this velociraptor package. This patch fixes these. Should only be merged once theload_fof_cataloguesbranch on swiftsimio is merged.