-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Che bato/deck page #164
base: main
Are you sure you want to change the base?
Che bato/deck page #164
Conversation
CheBato
commented
Mar 2, 2025
•
edited
Loading
edited
- Added Deck page for annonymous users.
- A player can add decks to localstorage from swustats or swudb.
- A player can add decks to localstorage via the favourites check on the main page.
- A player can add decks to localstorage in the lobby.
- A player can use decks from localstorage in the main menu for quick games and custom games
- A player can change his deck to one from localstorage in lobby.
- Added error handling when a favourite deck suddenly becomes unlisted or other error while still being in the localStorage.
- Added visual candy for the user when they take a look at their decks.
- Added 3 types of sorts in the deckPage. by favourites, name and deck source.
- Disabled order by in the detailed deckPage.
# Conflicts: # src/app/_components/_sharedcomponents/Cards/CardTypes.ts
Really like how this page is shaping up. I have some nots but since a lot of this is on the fly and this is a relatively complex page it could serve as a good reason to catch up and chat. Let me know if you would have some time for that tomorrow. Some things I might look at if you were going to work on anything before we have a chance to talk:
|
# Conflicts: # src/app/_components/_sharedcomponents/Popup/Popup.tsx # src/app/_components/_sharedcomponents/Popup/PopupVariant/LeaveGamePopup.tsx
src/app/_components/_sharedcomponents/QuickGameForm/QuickGameForm.tsx
Outdated
Show resolved
Hide resolved
src/app/_components/_sharedcomponents/CreateGameForm/CreateGameForm.tsx
Outdated
Show resolved
Hide resolved
Overall really good stuff. I'm not gonna nit picky here cause the important thing is that it's functinoal and we can clean it up later. One thing I forgot to comment on is that I would really like for the lobby to default to showing the decks drop down at first if there are decks to be shown and have the button say "Load deck". Probably locaked above that would be a text link that says "import new deck" and clicking that would show the deck link input with a button saying "Import deck". That may be a post feature thing unless you think you can whip that up quickly. But the purpose is just to save as much space there as we can but also be super clear about if the user is using one of their preexisting decks or loading up a new one. Let me know what you think. |
I got it working :D I would only kindly ask you if you could just move it to where it you think it would be best. Otherwise I think it was a great idea to include the swapping between one and the other. Let me know what you think! |