Che bato/custom decks #25
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
CheBato
commented
Dec 10, 2024
CheBato
commented
- Renamed S3Assets to S3Utils
- Added utility functions to convert deck data from SWUDB to deck data compatible with the server. Located in the s3Utils.ts
- Added a new GET method in the API/S3Bucket/route.ts to receive json files from the S3Bucket.
- Inbetween changes
- Inbetween changes
- Changed the way we convert decks to backend readable format. - Renamed s3Assets to s3Utils.ts - Added two helper functions for converting deck data.
- Added mapping from swuDb -> to actual deck information that is sent to the server. - Need to clean up the code.
- Cleaned up code for PR
- Cleaned up code for PR part 2
AMMayberry1
reviewed
Dec 10, 2024
danbastin
reviewed
Dec 10, 2024
- renamed interfaces
- renamed Types to include I
danbastin
approved these changes
Dec 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.