Che bato/lobby design #26
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
CheBato
commented
Dec 15, 2024
CheBato
commented
- Divided the LeaderBaseCard to LeaderCard and BaseCard for more flexability
- Changed the design of the lobby to be similar to designs
- Added counter to the gameCards so we can see the amount of a certain card.
- Added Sideboard design and functionality to lobby.
- Changed the design of the leaders and base for the lobby.
- Changed how the Chat and Setup column looks in the lobby.
- Added API call to the server to update the deck information for the game (sideboarding).
- Added resizing of cards and elements in the lobby to support smaller screens.
- Started with lobby design.
- Inbetween changes
- Changed Lobby design to go with the figma designs.
- Made changes to the lobby design to better go with the design in figma.
…LobbyDesign # Conflicts: # src/app/_components/_sharedcomponents/LeaderBaseBoard/LeaderBase/LeaderBase.tsx
- Added new design changes to the lobby. - Added card counters to the lobby.
- Added functionality of changing the deck with the sideboard.
- Divided the Leader and Base cards. - Added support for smaller screens the lobby. - Added Sideboard support - Correctly count the amount of cards in both the deck and sideboard. - Send the deck to the server before starting the game.
- Cleaned up the code for PR
- Cleaned up the code for PR
- Cleaned up the code for PR
danbastin
reviewed
Dec 16, 2024
src/app/_components/_sharedcomponents/Cards/LeaderCard/LeaderCard.tsx
Outdated
Show resolved
Hide resolved
src/app/_components/_sharedcomponents/LeaderBaseBoard/LeaderBaseBoard.tsx
Outdated
Show resolved
Hide resolved
src/app/_components/_sharedcomponents/Cards/GameCard/GameCard.tsx
Outdated
Show resolved
Hide resolved
- Cleaned up code for PR resolved some comments
- Cleaned up the code for PR
- Cleaned last comment for PR
- Cleaned a bug.
- Cleaned a bug.
danbastin
reviewed
Dec 17, 2024
src/app/_components/_sharedcomponents/Cards/GameCard/GameCard.tsx
Outdated
Show resolved
Hide resolved
src/app/_components/_sharedcomponents/Cards/LeaderBaseCard/LeaderBaseCard.tsx
Outdated
Show resolved
Hide resolved
src/app/_components/_sharedcomponents/Cards/LeaderBaseCard/LeaderBaseCard.tsx
Outdated
Show resolved
Hide resolved
- Added changes for the comments on the PR.
- Fixed bug
danbastin
approved these changes
Dec 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.