Che bato/private lobbies #39
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
CheBato
commented
Jan 3, 2025
•
CheBato
commented
- Added ability to create private lobbies.
- Added link support for joining game.
- Refactored FetchDeckData since we are using it in three locations I made it as a utility function.
- homestretch
- added copy invite link.
- Fixed bug with usernames and ids for the game.
- Adjusted FE to work with changes to the BE.
- Adjusted FE to work with changes to the BE.
- Cleaned console.logs
|
I hit an error when trying to pick first player while I was player 2. Seems like the player name was not being set for the game. CardClicked should probably be switched to use the players id instead of their name, but it would probably be good to have it working either way. |
Absolutely seems like I missed this during my initial testing. I'll have a look and fix it up asap. My mistake |
- Fixed bug with privateLobbies and username. in the Game.context.tsx we had to add username to the JSON user when setting the newSocket since once we set the socket it cannot be changed.
- Added X functionality to the gameboard so that we can return to the homepage when clicking X.
danbastin
approved these changes
Jan 7, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.