Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Experimental Fixes to the Mapgen #1

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Experimental Fixes to the Mapgen #1

wants to merge 1 commit into from

Conversation

Saalvage
Copy link
Owner

@Saalvage Saalvage commented Jan 2, 2025

I find it an interesting study to fix the mapgen algorithm so it never throws with differing map sizes, while maintaining exact consistency for all existing, working configurations (sizes + seeds).

To make sure that none of the changes chance existing seeds we should generate a large corpus of generated maps we can compare the fixed algorithm's output to.

A few things to consider:

  • Different map sizes take differently sized pieces of their provided pie, this gives rise to the consideration of what the actual size returned by the mapgen should be. Shrinking the array to fit the map seems like a reasonable solution. An alternative would be taking the maximum available (the internal array's size).
  • Configurations that utilize the horizontal edges end up corrupted, same goes for configurations with very little vertical space (it should be checked if/how this behavior differs from the original implementation, even if it's erroneous).

Cute lil' broken map
ll10j3m

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant