[ORCA-288] Test Object Naming Refactor #52
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BryanFauble
approved these changes
Dec 12, 2023
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #52 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 24 24
Lines 1184 1184
Branches 192 192
=========================================
Hits 1184 1184 ☔ View full report in Codecov by Sentry. |
thomasyu888
approved these changes
Dec 13, 2023
…/fix_tox [ORCA-294] Fix `tox` implementation in CI pipeline
…9/refactor_tests_in_classes
…/refactor_tests_in_classes [ORCA-289] Refactor External and Internal Testing Unit Tests as Test Classes
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem:
The test file, target, and suite objects defined in
conftest.pythat we use in our unit tests have confusing names, making it difficult to know what is happening in our tests.Solution:
Change the names to a loose convention of
good_<type_of_file>for "good" files and<reason_why_this_file_is_bad_<type_of_file>for "bad" files.Notes:
conftest.py.