Skip to content

Commit

Permalink
feat(Color picker)!: Delete label tokens. (#458)
Browse files Browse the repository at this point in the history
* feat!(Color picker): Delete unused label tokens.
BREAKING CHANGE: form.color.colorpicker.[hue].label removed for all hues.

* feat(data): XXXL padding option needed for right margin on chat bubbles

* feat(chatbubble)!: removing chat bubble spacing tokens as they are no longer needed. Tile component tokens are what we will use for chat bubble.

* feat(modes): adding important status color of purple to dark and light mode.

* feat(tile): adding status border colors.

* updating description in status width borders

* removing redundant green primitive token

---------

Co-authored-by: Luke Emmerson-Finch <[email protected]>
  • Loading branch information
clairedenning and ljemmo authored Mar 6, 2025
1 parent c8f88d3 commit d47f578
Show file tree
Hide file tree
Showing 6 changed files with 56 additions and 188 deletions.
45 changes: 0 additions & 45 deletions data/tokens/$themes.json

Large diffs are not rendered by default.

135 changes: 42 additions & 93 deletions data/tokens/components/container.json
Original file line number Diff line number Diff line change
Expand Up @@ -362,6 +362,36 @@
"$type": "color",
"$value": "{modes.color.generic.content.harsh}",
"$description": "for headings, paragraph text etc "
},
"statusborder": {
"bg-ai": {
"$type": "color",
"$value": "{container.color.AI.bordervertical}"
},
"bg-caution": {
"$type": "color",
"$value": "{modes.color.status.caution.default}"
},
"bg-negative": {
"$type": "color",
"$value": "{modes.color.status.negative.default}"
},
"bg-important": {
"$type": "color",
"$value": "{modes.color.status.important.default}"
},
"bg-info": {
"$type": "color",
"$value": "{modes.color.status.info.default}"
},
"bg-neutral": {
"$type": "color",
"$value": "{modes.color.status.neutral.default}"
},
"bg-positive": {
"$type": "color",
"$value": "{modes.color.status.positive.default}"
}
}
}
},
Expand Down Expand Up @@ -608,6 +638,13 @@
}
}
},
"tile": {
"statusborder": {
"$type": "sizing",
"$value": "{global.size.micro.M}",
"$description": "width of left status borders on tiles."
}
},
"tileselect": {
"footer": {
"$type": "sizing",
Expand Down Expand Up @@ -675,10 +712,6 @@
"$value": "{global.radius.container.L}",
"$description": "Carousel slides"
},
"chatbubble": {
"$type": "borderRadius",
"$value": "{global.radius.container.L}"
},
"colorpicker": {
"$type": "borderRadius",
"$value": "{global.radius.container.L}",
Expand Down Expand Up @@ -783,81 +816,6 @@
}
}
},
"chatbubble": {
"outer": {
"x": {
"M": {
"$type": "spacing",
"$value": "{global.space.macro.M}",
"$description": "Left margin on AI response bubbles and right margin on user prompt bubbles."
},
"L": {
"$type": "spacing",
"$value": "{global.space.macro.XL} * 2",
"$description": "Right margin on AI response bubbles and left margin on user prompt bubbles."
}
},
"y": {
"M": {
"$type": "spacing",
"$value": "{global.space.micro.L}",
"$description": "Top and bottom margin on all chat bubbles."
}
},
"yg": {
"M": {
"$type": "spacing",
"$value": "{global.space.micro.S}",
"$description": "Gap between timestamp and chat bubble container. Also gap between give feedback button and container."
}
}
},
"inner": {
"x": {
"M": {
"$type": "spacing",
"$value": "{global.space.macro.XS}",
"$description": "Left and right padding inside chat bubbles."
}
},
"xg": {
"S": {
"$type": "spacing",
"$value": "{global.space.micro.L}"
},
"M": {
"$type": "spacing",
"$value": "{global.space.macro.XS}"
}
},
"Y": {
"M": {
"$type": "spacing",
"$value": "{global.space.macro.XS}",
"$description": "Top and bottom padding inside chat bubbles."
}
},
"yg": {
"XS": {
"$type": "spacing",
"$value": "{global.space.micro.S}"
},
"S": {
"$type": "spacing",
"$value": "{global.space.micro.L}"
},
"M": {
"$type": "spacing",
"$value": "{global.space.macro.XS}"
},
"L": {
"$type": "spacing",
"$value": "{global.space.macro.M}",
"$description": "Vertical gap between inner blocks within a chat or insight bubble."
}
}
}
},
"filepreview": {
"preview": {
"x": {
Expand Down Expand Up @@ -1353,6 +1311,11 @@
"$type": "spacing",
"$value": "{global.space.macro.L}",
"$description": "Right left padding on Tile or Card."
},
"XXXL": {
"$type": "spacing",
"$value": "{global.space.macro.XL} * 2",
"$description": "Right margin on AI response bubbles and left margin on user prompt bubbles."
}
},
"xg": {
Expand Down Expand Up @@ -1665,20 +1628,6 @@
"$description": "Accordion subtle (content vertical line)"
}
},
"chatbubble": {
"default": {
"$type": "borderWidth",
"$value": "{global.borderwidth.XS}"
},
"error": {
"$type": "borderWidth",
"$value": "{global.borderwidth.S}"
},
"success": {
"$type": "borderWidth",
"$value": "{global.borderwidth.S}"
}
},
"filepreview": {
"container": {
"$type": "borderWidth",
Expand Down
45 changes: 0 additions & 45 deletions data/tokens/components/form.json
Original file line number Diff line number Diff line change
Expand Up @@ -1199,11 +1199,6 @@
"pattern": {
"$type": "color",
"$value": "{modes.color.colorcode.blue.deep}"
},
"label-default": {
"$type": "color",
"$value": "{modes.color.colorcode.blue.deep}",
"$description": "At least 4.5:1 against #F3 (light mode) and #0E (dark mode). Not to be used on bg-default."
}
},
"teal": {
Expand All @@ -1222,11 +1217,6 @@
"pattern": {
"$type": "color",
"$value": "{modes.color.colorcode.teal.deep}"
},
"label-default": {
"$type": "color",
"$value": "{modes.color.colorcode.teal.deep}",
"$description": "At least 4.5:1 against #F3 (light mode) and #0E (dark mode). Not to be used on bg-default."
}
},
"green": {
Expand All @@ -1245,11 +1235,6 @@
"pattern": {
"$type": "color",
"$value": "{modes.color.colorcode.green.deep}"
},
"label-default": {
"$type": "color",
"$value": "{modes.color.colorcode.green.deep}",
"$description": "At least 4.5:1 against #F3 (light mode) and #0E (dark mode). Not to be used on bg-default."
}
},
"lime": {
Expand All @@ -1268,11 +1253,6 @@
"pattern": {
"$type": "color",
"$value": "{modes.color.colorcode.lime.deep}"
},
"label-default": {
"$type": "color",
"$value": "{modes.color.colorcode.lime.deep}",
"$description": "At least 4.5:1 against #F3 (light mode) and #0E (dark mode). Not to be used on bg-default."
}
},
"orange": {
Expand All @@ -1291,11 +1271,6 @@
"pattern": {
"$type": "color",
"$value": "{modes.color.colorcode.orange.deep}"
},
"label-default": {
"$type": "color",
"$value": "{modes.color.colorcode.orange.deep}",
"$description": "At least 4.5:1 against #F3 (light mode) and #0E (dark mode). Not to be used on bg-default."
}
},
"red": {
Expand All @@ -1314,11 +1289,6 @@
"pattern": {
"$type": "color",
"$value": "{modes.color.colorcode.red.deep}"
},
"label-default": {
"$type": "color",
"$value": "{modes.color.colorcode.red.deep}",
"$description": "At least 4.5:1 against #F3 (light mode) and #0E (dark mode). Not to be used on bg-default."
}
},
"pink": {
Expand All @@ -1337,11 +1307,6 @@
"pattern": {
"$type": "color",
"$value": "{modes.color.colorcode.pink.deep}"
},
"label-default": {
"$type": "color",
"$value": "{modes.color.colorcode.pink.deep}",
"$description": "At least 4.5:1 against #F3 (light mode) and #0E (dark mode). Not to be used on bg-default."
}
},
"purple": {
Expand All @@ -1360,11 +1325,6 @@
"pattern": {
"$type": "color",
"$value": "{modes.color.colorcode.purple.deep}"
},
"label-default": {
"$type": "color",
"$value": "{modes.color.colorcode.purple.deep}",
"$description": "At least 4.5:1 against #F3 (light mode) and #0E (dark mode). Not to be used on bg-default."
}
},
"gray": {
Expand All @@ -1383,11 +1343,6 @@
"pattern": {
"$type": "color",
"$value": "{modes.color.colorcode.gray.deep}"
},
"label-default": {
"$type": "color",
"$value": "{modes.color.colorcode.gray.deep}",
"$description": "At least 4.5:1 against #F3 (light mode) and #0E (dark mode). Not to be used on bg-default."
}
},
"slate": {
Expand Down
7 changes: 7 additions & 0 deletions data/tokens/modes/dark.json
Original file line number Diff line number Diff line change
Expand Up @@ -1400,6 +1400,13 @@
"$value": "{primitives.colors.blush}"
}
},
"important": {
"default": {
"$type": "color",
"$value": "{primitives.colors.supplementary.purple.500}",
"$description": "For tile status keylines to show if something is of high importance."
}
},
"neutral": {
"default": {
"$type": "color",
Expand Down
7 changes: 7 additions & 0 deletions data/tokens/modes/light.json
Original file line number Diff line number Diff line change
Expand Up @@ -1418,6 +1418,13 @@
}
}
},
"important": {
"default": {
"$type": "color",
"$value": "{primitives.colors.supplementary.purple.400}",
"$description": "For tile status keylines to show if something is of high importance."
}
},
"negative": {
"default": {
"$type": "color",
Expand Down
5 changes: 0 additions & 5 deletions data/tokens/primitives.json
Original file line number Diff line number Diff line change
Expand Up @@ -31,11 +31,6 @@
"$value": "#008046",
"$description": "Legacy green used on old product theme"
},
"green": {
"$type": "color",
"$value": "#8b00f9",
"$description": "Base status color for light surface. AAA text on white. Color taken from brand portal."
},
"verdant": {
"$type": "color",
"$value": "#009023",
Expand Down

0 comments on commit d47f578

Please sign in to comment.