Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix bug, dont delete element of try_update_with fails. #14

Merged
merged 2 commits into from
Dec 22, 2023

Conversation

Sajjon
Copy link
Owner

@Sajjon Sajjon commented Dec 22, 2023

No description provided.

Copy link

codecov bot commented Dec 22, 2023

Codecov Report

Attention: 2 lines in your changes are missing coverage. Please review.

Comparison is base (a6299e5) 95.33% compared to head (a4379bb) 95.00%.

Files Patch % Lines
src/vec/identified_vec.rs 71.42% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main      #14      +/-   ##
==========================================
- Coverage   95.33%   95.00%   -0.34%     
==========================================
  Files           8        8              
  Lines         236      240       +4     
==========================================
+ Hits          225      228       +3     
- Misses         11       12       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Sajjon Sajjon merged commit 9144399 into main Dec 22, 2023
1 of 3 checks passed
@Sajjon Sajjon deleted the fix_bug_dont_delete_element_if-try_update_with_fails branch December 22, 2023 09:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant