Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Redirect combine, deflate, & gather output to stdout #81

Merged
merged 2 commits into from
Nov 26, 2024

Conversation

douglatornell
Copy link
Member

@douglatornell douglatornell commented Nov 25, 2024

Updated the run.py script and related tests to ensure that the output of the combine, deflate, and gather commands in run scripts for salish is redirected to ${RESULTS_DIR}/stdout. This was overlooked in PR #80.

Updated the `run.py` script and related tests to ensure that the output of
the combine, deflate, and gather commands is redirected to
`${RESULTS_DIR}/stdout`. This was overlooked in PR#80.
@douglatornell douglatornell added bug Something isn't working run plug-in labels Nov 25, 2024
@douglatornell douglatornell added this to the v24.2 milestone Nov 25, 2024
Copy link

codecov bot commented Nov 25, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 95.37%. Comparing base (ec1529a) to head (05cb189).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main      #81   +/-   ##
=======================================
  Coverage   95.37%   95.37%           
=======================================
  Files          10       10           
  Lines        1362     1362           
  Branches       77       77           
=======================================
  Hits         1299     1299           
  Misses         58       58           
  Partials        5        5           
Flag Coverage Δ
unittests 95.37% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@douglatornell douglatornell merged commit 1d2c9dc into main Nov 26, 2024
10 checks passed
@douglatornell douglatornell deleted the add-more-salish-redirects branch November 26, 2024 22:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working run plug-in
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant