Skip to content

Commit

Permalink
Fix Baynes Sound AGRIF figure (#326)
Browse files Browse the repository at this point in the history
* Replace the bathymetry URL with a grid repo path

Replaced the bathymetry URL reference in the Baynes Sound AGRIF figure
configuration with a local grid path because the V17-02 bathymetry dataset has
been removed from the ERDDAP server. Adjusted related test cases and updated the
figure development and testing notebooks to align with the new configuration.

* Use h5netcdf engine for xarray dataset loading

The change ensures consistent use of the h5netcdf engine when opening datasets
with xarray. This improves compatibility and aligns with recommended practices
for handling NetCDF files in the workflow.

* Fix array handling in contour level calculation

Previously, the contour level calculation used non-scalar types directly,
causing errors. Added `.values` to ensure proper handling of scalar values
extracted from xarray objects. This issue arose with the change to `numpy>=2`.
  • Loading branch information
douglatornell authored Jan 23, 2025
1 parent fd4419c commit 32ac2ba
Show file tree
Hide file tree
Showing 6 changed files with 510 additions and 214 deletions.
2 changes: 0 additions & 2 deletions config/nowcast.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -538,8 +538,6 @@ erddap:
figures:
# ERDDAP dataset URLs
dataset URLs:
bathymetry:
https://salishsea.eos.ubc.ca/erddap/griddap/ubcSSnBathymetryV17-02
HRDPS fields:
https://salishsea.eos.ubc.ca/erddap/griddap/ubcSSaSurfaceAtmosphereFieldsV23-02
tide stn ssh time series:
Expand Down
Loading

0 comments on commit 32ac2ba

Please sign in to comment.