fix(api): fixed the the app.e2e-spec.ts by mocking the PrismaService #140
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Open
46 tasks
|
@AnshulMalik @yuvrajsab can you please review this Thanks!! |
|
Hey @varun7singh, Thanks for the PR. The current mock approach, we won't be able to test the actual functionality in future, we need to mock the client, but should behave like prisma client and not connect to actual database at the same time. Here is how the official documentation suggests: |
|
Oh okay sure |
|
@AnshulMalik do look into this PR i referred to the docs and use mockDeep to create a mock instance of PrismaService do let me know for any more changes Thanks !! |
AnshulMalik
approved these changes
May 30, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
changed the file layout a bit there was no PrimsaModule so used nest CLI to generate it made sure everythingworks
closes #132