Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat(Link-expiry): Added link expiry using redis #83

Merged
merged 11 commits into from
Aug 11, 2023

Conversation

Nazi-pikachu
Copy link
Collaborator

Description

This draft pull request introduces the link expiry feature, allowing links to automatically expire after a specified period.
The implementation includes adding a layer of redis on the top of postgres and Setting up TTL in redis

Related Issue

#22
#52

@Nazi-pikachu
Copy link
Collaborator Author

Hey @yuvrajsab
This is a draft PR with a minimal implementation of link-expiry using redis.
I am thinking of making RMQ durable Rather than non-durable since we can't afford data loss if we want to sync both the db using it.

@yuvrajsab
Copy link
Member

@Nazi-pikachu yes please make it durable.

apps/api/src/app/app.service.ts Outdated Show resolved Hide resolved
apps/api/src/app/app.service.ts Outdated Show resolved Hide resolved
apps/api/src/app/app.controller.ts Outdated Show resolved Hide resolved
@Nazi-pikachu Nazi-pikachu marked this pull request as ready for review August 10, 2023 20:14
@Nazi-pikachu
Copy link
Collaborator Author

Nazi-pikachu commented Aug 10, 2023

This is final PR
It includes the following changes

  1. Adding a layer of redis on top of postgres
  2. Updating the relavant services to support this
  3. Integrating with RMQ to increase the cick_count in DB async Integrate RMQ #74
  4. Refactoring the backend code to be more modular
  5. Adding docString to make code more readable
  6. Fixes few bugs and edge cases previously missing
  7. Support for LINK-EXPIRY added Expiry for Links #22

Copy link
Member

@yuvrajsab yuvrajsab left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm.

apps/api/src/app/app.controller.ts Outdated Show resolved Hide resolved
apps/api/src/app/app.controller.ts Outdated Show resolved Hide resolved
@yuvrajsab yuvrajsab merged commit fb10ddd into Samagra-Development:master Aug 11, 2023
1 of 3 checks passed
This was referenced Aug 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants