Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

IPv4 location markup #101

Merged
merged 2 commits into from
Mar 14, 2024
Merged

IPv4 location markup #101

merged 2 commits into from
Mar 14, 2024

Conversation

Yullia
Copy link
Contributor

@Yullia Yullia commented Mar 12, 2024 •
edited
Loading

IPv5 location markup for True (batch 1- 50)

@Yullia Yullia marked this pull request as ready for review March 12, 2024 12:04
@Yullia Yullia requested a review from a team as a code owner March 12, 2024 12:04
babenek
babenek requested changes Mar 12, 2024
View reviewed changes
Copy link
Contributor

@babenek babenek left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

add PredefinedPattern="Info" to skip the obfuscation
'214.293.362.630' - becomes not an IP

Yullia
Yullia commented Mar 12, 2024
View reviewed changes
meta/7f0408de.csv Outdated Show resolved Hide resolved
Yullia
Yullia commented Mar 12, 2024
View reviewed changes
meta/7f0408de.csv Outdated Show resolved Hide resolved
Yullia
Yullia commented Mar 12, 2024
View reviewed changes
meta/7f0408de.csv Outdated Show resolved Hide resolved
Yullia
Yullia commented Mar 12, 2024
View reviewed changes
meta/7f0408de.csv Outdated Show resolved Hide resolved
Yullia
Yullia commented Mar 12, 2024
View reviewed changes
meta/81cd05d0.csv Outdated Show resolved Hide resolved
Yullia
Yullia commented Mar 12, 2024
View reviewed changes
meta/850c2319.csv Outdated Show resolved Hide resolved
Yullia
Yullia commented Mar 12, 2024
View reviewed changes
meta/894e3377.csv Outdated Show resolved Hide resolved
Yullia
Yullia commented Mar 12, 2024
View reviewed changes
meta/8c9b3ae9.csv Outdated Show resolved Hide resolved
Yullia
Yullia commented Mar 12, 2024
View reviewed changes
meta/8d217d6c.csv Outdated Show resolved Hide resolved
Yullia
Yullia commented Mar 12, 2024
View reviewed changes
meta/9128de73.csv Outdated Show resolved Hide resolved
Yullia
Yullia commented Mar 12, 2024
View reviewed changes
meta/9bc5ca9e.csv Outdated Show resolved Hide resolved
Yullia
Yullia commented Mar 12, 2024
View reviewed changes
meta/9d90ba70.csv Outdated Show resolved Hide resolved
Yullia
Yullia commented Mar 12, 2024
View reviewed changes
meta/a09d9e50.csv Outdated Show resolved Hide resolved
Yullia
Yullia commented Mar 12, 2024
View reviewed changes
meta/a09d9e50.csv Outdated Show resolved Hide resolved
Yullia
Yullia commented Mar 12, 2024
View reviewed changes
meta/a09d9e50.csv Outdated Show resolved Hide resolved
babenek
babenek approved these changes Mar 12, 2024
View reviewed changes
Copy link
Contributor

@babenek babenek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@iuriimet iuriimet self-requested a review March 14, 2024 07:24
@babenek babenek merged commit a2696af into Samsung:main Mar 14, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@iuriimet iuriimet iuriimet approved these changes

@babenek babenek babenek approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Yullia @babenek @iuriimet