Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

IPv4 location markup batch 3 #103

Merged
merged 7 commits into from
Mar 19, 2024
Merged

IPv4 location markup batch 3 #103

merged 7 commits into from
Mar 19, 2024

Conversation

Yullia
Copy link
Contributor

@Yullia Yullia commented Mar 12, 2024

IPv4 location markup batch 3 (100-150)

@Yullia Yullia marked this pull request as ready for review March 12, 2024 12:37
@Yullia Yullia requested a review from a team as a code owner March 12, 2024 12:37
babenek
babenek requested changes Mar 12, 2024
View reviewed changes
Copy link
Contributor

@babenek babenek left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

use Info for an IP address markup (TRUE - mandatory, FALSE - not necessary)

Yullia
Yullia commented Mar 12, 2024
View reviewed changes
meta/894e3377.csv Outdated Show resolved Hide resolved
Yullia
Yullia commented Mar 12, 2024
View reviewed changes
meta/894e3377.csv Outdated Show resolved Hide resolved
Yullia
Yullia commented Mar 12, 2024
View reviewed changes
meta/99f9a6ea.csv Outdated Show resolved Hide resolved
Yullia
Yullia commented Mar 12, 2024
View reviewed changes
meta/a0cd6261.csv Outdated Show resolved Hide resolved
Yullia
Yullia commented Mar 12, 2024
View reviewed changes
meta/a0cd6261.csv Outdated Show resolved Hide resolved
Yullia
Yullia commented Mar 12, 2024
View reviewed changes
meta/a0cd6261.csv Outdated Show resolved Hide resolved
Yullia
Yullia commented Mar 12, 2024
View reviewed changes
meta/a0cd6261.csv Outdated Show resolved Hide resolved
Yullia
Yullia commented Mar 12, 2024
View reviewed changes
meta/a0cd6261.csv Outdated Show resolved Hide resolved
Yullia
Yullia commented Mar 12, 2024
View reviewed changes
meta/a0cd6261.csv Outdated Show resolved Hide resolved
@Yullia Yullia requested a review from babenek March 12, 2024 17:58
babenek
babenek previously approved these changes Mar 13, 2024
View reviewed changes
Copy link
Contributor

@babenek babenek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@iuriimet iuriimet self-requested a review March 14, 2024 07:21
iuriimet
iuriimet previously approved these changes Mar 14, 2024
View reviewed changes
@Yullia Yullia dismissed stale reviews from iuriimet and babenek via 0bf0608 March 14, 2024 08:17
babenek
babenek reviewed Mar 18, 2024
View reviewed changes
meta/894e3377.csv Outdated Show resolved Hide resolved
babenek
babenek approved these changes Mar 18, 2024
View reviewed changes
Copy link
Contributor

@babenek babenek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@babenek babenek merged commit 608d6de into Samsung:main Mar 19, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@iuriimet iuriimet iuriimet approved these changes

@babenek babenek babenek approved these changes

@xDizzix xDizzix Awaiting requested review from xDizzix

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Yullia @babenek @iuriimet