Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Markup password location in line #86

Merged
merged 6 commits into from
Feb 29, 2024
Merged

Markup password location in line #86

merged 6 commits into from
Feb 29, 2024

Conversation

Yullia
Copy link
Contributor

@Yullia Yullia commented Feb 29, 2024

No description provided.

@Yullia Yullia requested a review from a team as a code owner February 29, 2024 07:04
babenek
babenek reviewed Feb 29, 2024
View reviewed changes
Copy link
Contributor

@babenek babenek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

TP

meta/a53cc03a.csv Outdated Show resolved Hide resolved
babenek
babenek reviewed Feb 29, 2024
View reviewed changes
Copy link
Contributor

@babenek babenek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

suggest to change false password markup

meta/533c47c6.csv Outdated Show resolved Hide resolved
meta/f710ac3c.csv Outdated Show resolved Hide resolved
@babenek babenek self-requested a review February 29, 2024 09:01
babenek
babenek approved these changes Feb 29, 2024
View reviewed changes
Copy link
Contributor

@babenek babenek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for adding correct markup of value!

@Yullia Yullia merged commit e615f76 into Samsung:main Feb 29, 2024
3 checks passed
@Yullia Yullia deleted the password_markup branch February 29, 2024 09:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@babenek babenek babenek approved these changes

@xDizzix xDizzix xDizzix approved these changes

@iuriimet iuriimet Awaiting requested review from iuriimet

@Dmitriy-NK Dmitriy-NK Awaiting requested review from Dmitriy-NK

@csh519 csh519 Awaiting requested review from csh519

@kmnls kmnls Awaiting requested review from kmnls

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Yullia @xDizzix @babenek