Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Increase max line length to 8000 #474

Merged
merged 15 commits into from
Dec 13, 2023
Merged

Increase max line length to 8000 #474

merged 15 commits into from
Dec 13, 2023

Conversation

babenek
Copy link
Contributor

@babenek babenek commented Dec 7, 2023 •
edited
Loading

Description

Please include a summary of the change and which is fixed.

  • Increase maximal line lengtht to 8000
  • small slowdown for benchmark (2%)

How has this been tested?

Please describe the tests that you ran to verify your changes.

@babenek babenek changed the title set max line length to 65536 Increase max line length to 65536 Dec 7, 2023
@codecov-commenter
Copy link

codecov-commenter commented Dec 7, 2023 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (b562a46) 90.72% compared to head (6b5eecb) 90.58%.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main     #474      +/-   ##
==========================================
- Coverage   90.72%   90.58%   -0.15%     
==========================================
  Files         126      126              
  Lines        4280     4280              
  Branches      679      679              
==========================================
- Hits         3883     3877       -6     
- Misses        262      267       +5     
- Partials      135      136       +1

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@babenek babenek marked this pull request as ready for review December 7, 2023 09:48
@babenek babenek requested a review from a team as a code owner December 7, 2023 09:48
@babenek babenek marked this pull request as draft December 11, 2023 10:16
@babenek babenek changed the title Increase max line length to 65536 Increase max line length to 20000 Dec 11, 2023
@babenek babenek changed the title Increase max line length to 20000 Increase max line length to 8000 Dec 12, 2023
@babenek babenek marked this pull request as ready for review December 12, 2023 21:38
@babenek babenek mentioned this pull request Dec 13, 2023
Merged
2 tasks
kmnls
kmnls previously approved these changes Dec 13, 2023
View reviewed changes
Copy link
Contributor

@kmnls kmnls left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Agree

Yullia
Yullia previously approved these changes Dec 13, 2023
View reviewed changes
csh519
csh519 previously approved these changes Dec 13, 2023
View reviewed changes
Copy link
Collaborator

@csh519 csh519 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Okay let's move up MAX_LINE_LENGTH to 8000.
But if the performance time increased abnormally, it can be reverted.

LGTM 👍

@csh519
Copy link
Collaborator

csh519 commented Dec 13, 2023

@xDizzix @babenek

Please monitor if this PR affects the internal service.

@babenek babenek dismissed stale reviews from csh519, Yullia, and kmnls via 6b5eecb December 13, 2023 15:27
@babenek babenek requested review from Yullia, kmnls and csh519 December 13, 2023 15:55
xDizzix
xDizzix approved these changes Dec 13, 2023
View reviewed changes
Copy link
Contributor

@xDizzix xDizzix left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

kmnls
kmnls approved these changes Dec 13, 2023
View reviewed changes
Copy link
Contributor

@kmnls kmnls left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Agree

@babenek babenek merged commit 7559f13 into Samsung:main Dec 13, 2023
29 checks passed
@babenek babenek deleted the longline branch December 13, 2023 16:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@xDizzix xDizzix xDizzix approved these changes

@kmnls kmnls kmnls approved these changes

@iuriimet iuriimet Awaiting requested review from iuriimet

@Dmitriy-NK Dmitriy-NK Awaiting requested review from Dmitriy-NK

@Yullia Yullia Awaiting requested review from Yullia

@csh519 csh519 Awaiting requested review from csh519

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@babenek @codecov-commenter @csh519 @xDizzix @Yullia @kmnls