[CfgEditor] Check properties existence in loop (#1685)

* [CfgEditor] Check properties existence in loop This commit checks properties' existence in for loop. * Update media/CfgEditor/index.js Co-authored-by: Seungho Henry Park <[email protected]> ONE-vscode-DCO-1.0-Signed-off-by: Dayoung Lee <[email protected]>
Samsung · Sep 26, 2023 · 4ba5ba1 · 4ba5ba1
1 parent 7b015c2
commit 4ba5ba1
Show file tree

Hide file tree

Showing 3 changed files with 21 additions and 13 deletions.
diff --git a/media/CfgEditor/displaycfg.js b/media/CfgEditor/displaycfg.js
@@ -149,9 +149,10 @@ export function displayCfgToEditor(cfg) {
     oneOptimize?.["output_path"]
   );
   for (const optName in oneOptimizationList) {
-    document.getElementById("checkboxOptimize" + optName).checked = cfgBoolean(
-      oneOptimize?.[optName]
-    );
+    if (Object.prototype.hasOwnProperty.call(oneOptimizationList, optName)) {
+      document.getElementById("checkboxOptimize" + optName).checked =
+        cfgBoolean(oneOptimize?.[optName]);
+    }
   }
 
   const oneQuantize = cfg["one-quantize"];

diff --git a/media/CfgEditor/index.js b/media/CfgEditor/index.js
@@ -347,6 +347,9 @@ function registerOptimizeOptions() {
   });
 
   for (const optName in oneOptimizationList) {
+    if (!Object.prototype.hasOwnProperty.call(oneOptimizationList, optName)) {
+      continue;
+    }
     let row = document.createElement("vscode-data-grid-row");
 
     let cellSwitch = document.createElement("vscode-data-grid-cell");
@@ -370,12 +373,14 @@ function registerOptimizeOptions() {
   }
 
   for (const optName in oneOptimizationList) {
-    document
-      .getElementById("checkboxOptimize" + optName)
-      .addEventListener("click", function () {
-        updateOptimize();
-        applyUpdates();
-      });
+    if (Object.prototype.hasOwnProperty.call(oneOptimizationList, optName)) {
+      document
+        .getElementById("checkboxOptimize" + optName)
+        .addEventListener("click", function () {
+          updateOptimize();
+          applyUpdates();
+        });
+    }
   }
 }
 

diff --git a/media/CfgEditor/updateContent.js b/media/CfgEditor/updateContent.js
@@ -286,10 +286,12 @@ export function updateOptimize() {
   );
 
   for (const optName in oneOptimizationList) {
-    content += iniKeyValueString(
-      optName,
-      document.getElementById("checkboxOptimize" + optName).checked
-    );
+    if (Object.prototype.hasOwnProperty.call(oneOptimizationList, optName)) {
+      content += iniKeyValueString(
+        optName,
+        document.getElementById("checkboxOptimize" + optName).checked
+      );
+    }
   }
 
   postMessageToVsCode({