Use eslint:recommended

.eslintrc.json

@@ -5,9 +5,13 @@
       "ecmaVersion": 6,
       "sourceType": "module"
   },
+  "extends": [
+    "eslint:recommended"
+  ],
   "plugins": [
       "@typescript-eslint"
   ],
+  "env": {"node": true, "mocha": true},
   "rules": {
       "@typescript-eslint/naming-convention": "warn",
       "@typescript-eslint/semi": "warn",

src/Backend/Command.ts

@@ -39,6 +39,6 @@ class Command extends Array<string> {
   str(): string {
     return (this.root ? 'sudo ' : '') + this.strs().join(' ');
   }
-};
+}
 
 export {Command};

src/Backend/Compiler.ts

@@ -88,6 +88,6 @@ class CompilerBase implements Compiler {
   prerequisitesForGetToolchains(): Command {
     throw Error('Invalid prerequisitesForGetToolchains call');
   }
-};
+}
 
 export {Compiler, CompilerBase};

src/Backend/Executor.ts

@@ -57,6 +57,6 @@ class ExecutorBase implements Executor {
   require(): DeviceSpec {
     throw new Error('NYI: need to define DeviceSpec for Executor.');
   }
-};
+}
 
 export {Executor, ExecutorBase};

src/Backend/Toolchain.ts

@@ -70,6 +70,6 @@ class Toolchain {
 // TODO: How to handle `nightly`?
 // TODO: Support MinimumVersion(): >=
 // TODO: Support filter(), where(), filter(regex) or orderBy()
-class Toolchains extends Array<Toolchain> {};
+class Toolchains extends Array<Toolchain> {}
 
 export {PackageInfo, ToolchainInfo, Toolchain, Toolchains};

src/Backend/ToolchainImpl/DebianToolchain.ts

@@ -129,6 +129,6 @@ class DebianToolchain implements Toolchain {
     cmd.push(cfg);
     return cmd;
   }
-};
+}
 
 export {DebianRepo, DebianArch, DebianToolchain};

src/Backend/Version.ts

@@ -47,6 +47,6 @@ class Version {
   }
 
   // TODO: Add operator <, <=, >, >=
-};
+}
 
 export {Version};

src/CfgEditor/CfgEditorPanel.ts

@@ -67,7 +67,7 @@ export class CfgEditorPanel implements vscode.CustomTextEditorProvider {
     ];
 
     registrations.forEach(disposable => context.subscriptions.push(disposable));
-  };
+  }
 
   constructor(private readonly context: vscode.ExtensionContext) {}
 
@@ -78,7 +78,7 @@ export class CfgEditorPanel implements vscode.CustomTextEditorProvider {
     await this.initWebview(document, webviewPanel.webview);
     this.initWebviewPanel(document, webviewPanel);
     this.updateWebview(document, webviewPanel.webview);
-  };
+  }
 
   private async initWebview(document: vscode.TextDocument, webview: vscode.Webview): Promise<void> {
     webview.options = {
@@ -195,5 +195,5 @@ export class CfgEditorPanel implements vscode.CustomTextEditorProvider {
       type: 'displayCfgToEditor',
       text: this._oneConfigMap[document.uri.toString()].getAsConfig()
     });
-  };
+  }
 }

src/CircleGraph/CircleGraphCtrl.ts

@@ -49,7 +49,7 @@ export class MessageDefs {
   public static readonly tensors = 'tensors';
   // partiton of backends
   public static readonly partition = 'partition';
-};
+}
 
 export interface CircleGraphEvent {
   onPageLoaded(): void;

src/CircleGraph/CircleViewer.ts

@@ -91,7 +91,7 @@ export class CircleViewerDocument implements vscode.CustomDocument {
 
     return view;
   }
-};
+}
 
 /**
  * @brief Circle model viewer readonly Provider
@@ -142,4 +142,4 @@ export class CircleViewerProvider implements
       _token: vscode.CancellationToken): Promise<void> {
     document.openView(webviewPanel, this._context.extensionUri);
   }
-};
+}

src/Jsontracer/JsonTracerViewerPanel.ts

@@ -63,7 +63,7 @@ export class JsonTracerViewerPanel implements vscode.CustomTextEditorProvider {
     ];
 
     registrations.forEach(disposable => context.subscriptions.push(disposable));
-  };
+  }
 
   constructor(private readonly context: vscode.ExtensionContext) {}
 
@@ -73,7 +73,7 @@ export class JsonTracerViewerPanel implements vscode.CustomTextEditorProvider {
     await this.initWebview(document, webviewPanel.webview);
     this.initWebviewPanel(document, webviewPanel);
     this.updateWebview(document, webviewPanel.webview);
-  };
+  }
 
   private async initWebview(document: vscode.TextDocument, webview: vscode.Webview): Promise<void> {
     webview.options = {
@@ -137,5 +137,5 @@ export class JsonTracerViewerPanel implements vscode.CustomTextEditorProvider {
     if (content !== undefined) {
       webview.postMessage({type: 'load', content: content, displayTimeUnit: displayTimeUnit});
     }
-  };
+  }
 }

src/OneExplorer/ArtifactLocator.ts

@@ -190,7 +190,7 @@ export class Locator {
 
     return filePaths;
   }
-};
+}
 
 
 // TODO Move to backend side with some modification

src/OneExplorer/ConfigObject.ts

@@ -290,4 +290,4 @@ export class ConfigObj {
 
     return artifacts;
   };
-};
+}

src/OneExplorer/OneExplorer.ts

@@ -752,4 +752,4 @@ input_path=${modelName}.${extName}
 
     return this.tree;
   }
-};
+}

src/PartEditor/PartEditor.ts

@@ -379,7 +379,7 @@ export class PartEditorProvider implements vscode.CustomTextEditorProvider, Part
     ];
 
     registrations.forEach(disposable => context.subscriptions.push(disposable));
-  };
+  }
 
   constructor(private readonly context: vscode.ExtensionContext) {
     this._extensionUri = context.extensionUri;
@@ -451,4 +451,4 @@ export class PartEditorProvider implements vscode.CustomTextEditorProvider, Part
           [vscode.Uri.joinPath(extensionUri, PartEditorProvider.folderMediaPartEditor)]
     };
   }
-};
+}

src/PartEditor/PartGraphSelector.ts

@@ -98,7 +98,7 @@ export class PartGraphSelPanel extends CircleGraphCtrl implements CircleGraphEve
     ];
 
     registrations.forEach(disposable => context.subscriptions.push(disposable));
-  };
+  }
 
   public static createOrShow(
       extensionUri: vscode.Uri, args: PartGraphCmdOpenArgs, handler: PartGraphEvent|undefined) {
@@ -286,4 +286,4 @@ export class PartGraphSelPanel extends CircleGraphCtrl implements CircleGraphEve
     let content = ini.parse(this._documentText);
     this.setPartition(content);
   }
-};
+}

src/Tests/OneExplorer/ConfigObject.test.ts

@@ -73,7 +73,7 @@ class TestBuilder {
       console.log(`Test ${this.testLabel} - Done`);
     }
   }
-};
+}
 
 suite('OneExplorer', function() {
   suite('ConfigObject', function() {
@@ -446,7 +446,7 @@ output_path=/dummy/dummy/../..//${productName2}
               configObj?.getProducts.map(product => product.path).includes(productPath1));
           assert.isFalse(
               configObj?.getProducts.map(product => product.path).includes(productPath2));
-          ;
+
         }
       });
 

src/Tests/OneExplorer/OneExplorer.test.ts

@@ -133,7 +133,7 @@ class TestBuilder {
       console.log(`Removed ${TestBuilder.rootInTemp} and ${TestBuilder.rootInTemp}.`);
     }
   }
-};
+}
 
 suite('OneExplorer', function() {
   setup(() => TestBuilder.setUp());

src/Tests/OneExplorer/OneStorage.test.ts

@@ -132,7 +132,7 @@ class TestBuilder {
       console.log(`Removed ${TestBuilder.rootInTemp} and ${TestBuilder.rootInTemp}.`);
     }
   }
-};
+}
 
 suite('OneExplorer', function() {
   suite('OneStorage', function() {

src/View/InstallQuickInput.ts

@@ -25,7 +25,7 @@ import {InputStep, MultiStepInput} from '../Utils/MultiStepInput';
 async function shouldResume() {
   // Could show a notification with the option to resume.
   return new Promise<boolean>(
-      (resolve, reject) => {
+      () => {
           // noop
       });
 }
@@ -268,7 +268,7 @@ class InstallQuickInput {
   }
 
   /* istanbul ignore next */
-  public async updateBackend(input: MultiStepInput, state: Partial<InstallQuickInputState>) {
+  public async updateBackend(input: MultiStepInput) {
     if (this.toolchainEnv === undefined || this.toolchainType === undefined) {
       this.error = 'toolchainenv is undefined.';
       throw Error('toolchainenv is undefined.');