Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[lint] Remove no-control-regex #1258

Merged
merged 4 commits into from
Sep 8, 2022
Merged

[lint] Remove no-control-regex #1258

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
9f70e91
[lint] Remove no-control-regex
dayo09 Sep 7, 2022
4fb3617
Add comments
dayo09 Sep 7, 2022
b37f253
Update src/View/PasswordQuickInput.ts
dayo09 Sep 7, 2022
e72d35f
format
dayo09 Sep 7, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions .eslintrc.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,6 +24,7 @@
"eqeqeq": "warn",
"no-throw-literal": "warn",
"semi": "off",
"no-control-regex": "warn",
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I put this above 'no-extra-semi' to avoid possible merge conflict

"no-extra-semi": "warn",
"no-case-declarations": "warn"
}
Expand Down
14 changes: 13 additions & 1 deletion src/View/PasswordQuickInput.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,8 +16,20 @@

import * as vscode from 'vscode';

// NOTE ASCII characters have codes ranging from u+0000 to u+007f
// NOTE
//
// u+0000-u+001f: control ascii codes, ascii (ALLOWED)
// u+0020-u+007f: printable ascii codes, ascii (ALLOWED)
// u+0080-u+00ff: extended ascii codes, extended ascii (NOT ALLOWED)
//
// By experience, Linux os takes all extended ascii characters(u+0000-u+00ff) for passwords, even
// controll asciis. whereas 'eslint' recommends not using regex including control ascii codes.
dayo09 marked this conversation as resolved.
Show resolved Hide resolved
// Therefore, we allow users to put control ascii codes.
//
// By experience, the passwords including extended ascii characters are not working when loging in
// to remote vscode. Therefore, here we allow only 'ascii characters'(0x00-0x7f).
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jyoungyun I tried several tests under what you've mentioned, I summarized here what I've found out. It seems that leaving the codes as-is is enough for now. PTAL :-D

function containsNonAscii(str: string): boolean {
// eslint-disable-next-line no-control-regex
return !/^[\u0000-\u007f]*$/.test(str);
}

Expand Down