-
Notifications
You must be signed in to change notification settings - Fork 51
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[lint] Remove no-prototype-builtins #1259
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dayo09
added
DRAFT
Something like playground
and removed
DRAFT
Something like playground
labels
Sep 6, 2022
seanshpark
previously approved these changes
Sep 6, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM thank you!
@Samsung/one-vscode PTAL :-D |
mhs4670go
previously approved these changes
Sep 7, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
it has some confilct. |
mhs4670go
reviewed
Sep 7, 2022
This commit adds "no-prototype-builtins" rule and fixes errors accordingly. ONE-vscode-DCO-1.0-Signed-off-by: dayo09 <[email protected]>
dayo09
force-pushed
the
0906-no-proto
branch
from
September 7, 2022 11:32
7aa2a5b
to
9de2daf
Compare
ONE-vscode-DCO-1.0-Signed-off-by: dayo09 <[email protected]>
dayo09
force-pushed
the
0906-no-proto
branch
from
September 7, 2022 11:34
9de2daf
to
8004867
Compare
@mhs4670go @seanshpark It's rebased. PTAL :-D |
seanshpark
approved these changes
Sep 7, 2022
mhs4670go
approved these changes
Sep 8, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit adds "no-prototype-builtins" rule and
fixes errors accordingly.
ONE-vscode-DCO-1.0-Signed-off-by: dayo09 [email protected]
For #1253