[lint] Remove unused variables from .js files #1300
Conversation
media/CircleGraph/index.js
Outdated
| @@ -492,7 +492,7 @@ host.BrowserHost = class { | |||
| this._view.setSelection(message); | |||
| } | |||
|
|
|||
| _msgColorTheme(message) { | |||
| _msgColorTheme() { | |||
There was a problem hiding this comment.
caller is this._msgColorTheme(message); please check caller.
media/CircleGraph/index.js
Outdated
| @@ -135,7 +135,7 @@ host.BrowserHost = class { | |||
| this._msgSelection(message); | |||
| break; | |||
| case 'colorTheme': | |||
| this._msgColorTheme(message); | |||
| this._msgColorTheme(); | |||
There was a problem hiding this comment.
I mean, do not remove message
This commit removes unused variables from .js files. ONE-vscode-DCO-1.0-Signed-off-by: Dayoung Lee <[email protected]>
| @@ -492,7 +492,7 @@ host.BrowserHost = class { | |||
| this._view.setSelection(message); | |||
| } | |||
|
|
|||
| _msgColorTheme(message) { | |||
| _msgColorTheme(_message) { | |||
There was a problem hiding this comment.
I could not fully understand why not to remove the argument. 😢 As the title of this pr, both message isn't used in the method.
@seanshpark @dayo09 Was there any background to remain the argument as variable but adding underscore in front of the name?
There was a problem hiding this comment.
because I wanted to preserve initial design of using message argument. currently I don't have time to take another look with other codes it would be appropriate to remove or not.
adding underscore will make ignore the tool used for unused variable as I know.
There was a problem hiding this comment.
@yunjayh Well I think so too. 😅 I just put the author's mind as the top priority. I introduced the underscore-ignoring rules to make a room for it.
This commit removes unused variables from .js files.
ONE-vscode-DCO-1.0-Signed-off-by: Dayoung Lee [email protected]
For #1299
From #1253