Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Toolchain] Implement profile in ToolchianProvider #1581

Merged

Conversation

jyoungyun
Copy link
Collaborator

This commit implements profile function in ToolchainProvider. This function calls the profile function of ToolchainEnv. It also adds vscode command for profile.

ONE-vscode-DCO-1.0-Signed-off-by: Jiyoung Yun [email protected]

Related issue: #1562

This commit implements profile function in ToolchainProvider. This function calls
the profile function of ToolchainEnv. It also adds vscode command for profile.

ONE-vscode-DCO-1.0-Signed-off-by: Jiyoung Yun <[email protected]>
@jyoungyun jyoungyun requested a review from a team June 21, 2023 05:47
Copy link
Contributor

@seanshpark seanshpark left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jyoungyun jyoungyun added the 1 approval 1 approval required to be merged label Jun 21, 2023
@jyoungyun
Copy link
Collaborator Author

This commit implements profile function in ToolchainProvider. This function calls
the profile function of ToolchainEnv. It also adds vscode command for profile.

ONE-vscode-DCO-1.0-Signed-off-by: Jiyoung Yun [email protected]

Public GitHub shows one signed-off comment when merging PR.
However, GitHub Enterprise works differently.

@seanshpark seanshpark merged commit 6fea66c into Samsung:main Jun 21, 2023
@jyoungyun jyoungyun deleted the profile/update_toolchain_provider branch June 21, 2023 09:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
1 approval 1 approval required to be merged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants