Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[onecc-docker] Use onecc version with a certain format #11049

Merged
merged 4 commits into from
Jul 18, 2023

Conversation

dayo09
Copy link
Contributor

@dayo09 dayo09 commented Jul 12, 2023

This commit requests github several latest version information and filter out versions like onert-micro-0.1.0
which doesn't include onecc package.

ONE-DCO-1.0.-Signed-off-by: Dayoung Lee [email protected]

@dayo09 dayo09 requested a review from jyoungyun July 12, 2023 03:30
@hseok-oh
Copy link
Contributor

hseok-oh commented Jul 12, 2023

https://github.com/Samsung/ONE/actions/runs/5527252181?pr=11049

diff --git a/compiler/onecc-docker/onecc-docker b/compiler/onecc-docker/onecc-docker
index 4d3bfef..9b57f44 100644
--- a/compiler/onecc-docker/onecc-docker
+++ b/compiler/onecc-docker/onecc-docker
@@ -42,8 +42,9 @@ class RequestHandler:
 
 
 def _request_recent_version(token=None):
-    response = RequestHandler(token, timeout=100).make_request(
-        url="https://api.github.com/repos/Samsung/ONE/releases")
+    response = RequestHandler(
+        token,
+        timeout=100).make_request(url="https://api.github.com/repos/Samsung/ONE/releases")
     versions = [release_item["tag_name"] for release_item in response.json()]
 
     for version in versions:

@hseok-oh
Copy link
Contributor

To resolve test fail on nncc-release, please rebase to latest master.

[2023-07-12T04:11:54.606Z] Traceback (most recent call last):
[2023-07-12T04:11:54.606Z]   File "preprocess_images.py", line 30, in <module>
[2023-07-12T04:11:54.606Z]     PIL.Image.ANTIALIAS)).astype(np.float32)
[2023-07-12T04:11:54.606Z] AttributeError: module 'PIL.Image' has no attribute 'ANTIALIAS'

Refer #10967

This commit requests github several latest version information
and filter out versions like onert-micro-0.1.0
which doesn't include onecc package.

ONE-DCO-1.0.-Signed-off-by: Dayoung Lee <[email protected]>
@dayo09 dayo09 force-pushed the 0712-one-docker branch from 471b5ed to b793f9a Compare July 12, 2023 06:37
@dayo09 dayo09 force-pushed the 0712-one-docker branch from b793f9a to df9fd04 Compare July 12, 2023 06:44
@dayo09 dayo09 added the PR/ready for review It is ready to review. Please review it. label Jul 12, 2023
Copy link
Contributor

@jyoungyun jyoungyun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM Thank you!

compiler/onecc-docker/onecc-docker Show resolved Hide resolved
@seanshpark seanshpark merged commit 61d8410 into Samsung:master Jul 18, 2023
@dayo09
Copy link
Contributor Author

dayo09 commented Jul 18, 2023

It's for Samsung/ONE-vscode#1604

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
PR/ready for review It is ready to review. Please review it.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants