Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[luci] Support TransposeConv activation #11467

Merged
merged 1 commit into from
Sep 4, 2023

Conversation

seanshpark
Copy link
Contributor

This will revise to support TransposeConv activation.

ONE-DCO-1.0-Signed-off-by: SaeHie Park [email protected]

@seanshpark
Copy link
Contributor Author

for #11390 , from #11387

This will revise to support TransposeConv activation.

ONE-DCO-1.0-Signed-off-by: SaeHie Park <[email protected]>
Copy link
Contributor

@jinevening jinevening left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

This change seems incompatible with the September release of our backend compiler (which is synced with circle schema version 5).

@seanshpark
Copy link
Contributor Author

seanshpark commented Sep 4, 2023

This change seems incompatible with the September release of our backend compiler

Yes, our September release will go with TF2.8.0 (ONE-compiler 1.24.0).

@jinevening
Copy link
Contributor

More details.

This change will make FuseActivationFunctionPass (included in O1) fuse activation functions to the preceding TConv. Our backend compiler may not handle such a model correctly.

@seanshpark
Copy link
Contributor Author

This change will make FuseActivationFunctionPass (included in O1) fuse activation functions to the preceding TConv

In upcoming PRs, FuseActivationFunctionPass for TransposeConv will be canceled.
And XpSepActFromTransposeConvPass will be introduced to separate fused activation from TransposeConv. This Pass will be removed someday when all backends supports fused activation.

@seanshpark seanshpark merged commit 192395e into Samsung:master Sep 4, 2023
3 checks passed
@seanshpark seanshpark deleted the luci_trconv_act branch September 4, 2023 06:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants