[infra/q-implant] Introduce q-implant Source Config #11535
Conversation
This PR includes a new external library, which is required for q-implant and has a MIT license. ONE-DCO-1.0-Signed-off-by: Junyeong Kang <[email protected]>
|
prev PR : #11534 I created a PR before, but I found a problem with my commit message. |
|
@nnfw-bot test onert-x64-release |
| @@ -0,0 +1,22 @@ | |||
| function(_LibnpySource_import) | |||
| if(NOT ${DOWNLOAD_LIBNPY}) | |||
There was a problem hiding this comment.
have you tested with DOWNLOAD_LIBNPY OFF ?
There was a problem hiding this comment.
Yes. I set the "DOWNLOAD_LIBNPY" option to "OFF" and proceeded with the test.
As a result, the configuration, build, and test processes of nncc worked without any problems.
Additionally, the test was also conducted when the configuration file of the q-implant module to be added in the future was built together.
In this case, no errors occurred during the entire test process, but this is due to the exception in CMakeLists.txt of q-implant.
(In CMakeLists.txt of q-implant, If LivnpySource_FOUND is false, exit without further building q-implant)
Therefore, the q-implant executable file is not created.
When I change the DOWNLOAD_LIBNPY option to ON and conduct the nncc configure, build process again, q-implant will be built successfully.
|
|
||
| ExternalSource_Download(LIBNPY | ||
| DIRNAME LIBNPY | ||
| URL ${LIBNPY_URL}) |
There was a problem hiding this comment.
why are DIRNAME LIBNPY and URL needed?
There was a problem hiding this comment.
The Libnpy required for 'q-implant' is an external library source that does not yet exist in ONE. Therefore, download is required.
'DINAME LIBNPY' and 'URL' are used to download external sources from other cmake file.
Therefore, I thought I could refer to it and use it.
There was a problem hiding this comment.
why I asked is that other lib files didn't seem to have this. plz check othe files and it would be better to follow like oyher filed.
There was a problem hiding this comment.
Thank you. I checked and found that it works without using "DINAME LIBNPY" and "URL". Fixed and committed again.
|
@nnfw-bot test onert-x64-release |
This is a commit fixed to follow the Code Convention in ExternalSource_Download. ONE-DCO-1.0-Signed-off-by: Junyeong Kang <[email protected]>
|
@nnfw-bot test nncc-jammy-debug |
|
LGTM thank you! |
for : #11254
draft : #11530
This PR includes a new external library, which is required for q-implant and has a MIT license.
ONE-DCO-1.0-Signed-off-by: Junyeong Kang [email protected]