Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[onert-micro] Reduce ArgMax and ArgMin code duplication #13291

Merged

Conversation

BalyshevArtem
Copy link
Contributor

This pr reduces code duplication for ArgMin and ArgMax.

for #13272

ONE-DCO-1.0-Signed-off-by: Artem Balyshev [email protected]

Torrero
Torrero previously approved these changes Jun 25, 2024
Copy link
Contributor

@Torrero Torrero left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

This pr reduces code duplication for ArgMin and ArgMax.

ONE-DCO-1.0-Signed-off-by: Artem Balyshev <[email protected]>
@BalyshevArtem
Copy link
Contributor Author

rebased to fix conflict

Torrero
Torrero previously approved these changes Jun 26, 2024
Copy link
Contributor

@Torrero Torrero left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM for merging

@chunseoklee chunseoklee requested a review from Torrero July 1, 2024 00:29
@BalyshevArtem BalyshevArtem merged commit 1389776 into Samsung:master Jul 1, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants