Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[onert-micro] Reducing code duplication #13293

Conversation

Torrero
Copy link
Contributor

@Torrero Torrero commented Jun 25, 2024

Reducing code duplication

Refactoring kernels: FloorDiv, FloorMod, Min, Max, GatherND for issue

ONE-DCO-1.0-Signed-off-by: Evgenii Maltsev [email protected]

…Max, GatherND

Refactoring kernels: FloorDiv, FloorMod, Min, Max, GatherND for [issue](Samsung#13272)

ONE-DCO-1.0-Signed-off-by:  Evgenii Maltsev [email protected]
@Torrero Torrero force-pushed the onert_micro_eliminate_duplication_lines_floor branch from 723a16c to b5cc43a Compare June 25, 2024 17:52
BalyshevArtem
BalyshevArtem previously approved these changes Jun 26, 2024
Copy link
Contributor

@BalyshevArtem BalyshevArtem left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but need to be rebased to resolve confilc in CMake file

Copy link
Contributor

@BalyshevArtem BalyshevArtem left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@BalyshevArtem BalyshevArtem merged commit 0a7eea9 into Samsung:master Jun 26, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants