[onert] Revisits python API #13583
Merged
[onert] Revisits python API #13583
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jiwaszki
reviewed
Aug 2, 2024
Comment on lines
25
to
28
| if operations: | ||
| session = nnfw_session(nnpackage_path, backends, operations) | ||
| session = nnfw_onert.onert.session(nnpackage_path, backends, operations) | ||
| else: | ||
| session = nnfw_session(nnpackage_path, backends) | ||
| session = nnfw_onert.onert.session(nnpackage_path, backends) |
There was a problem hiding this comment.
Just to point out the overload for onert.session(nnpackage_path, backends, operations) has been removed in #13468 Could it be removed in this PR along other changes?
| @@ -7,9 +7,9 @@ def main(nnpackage_path, backends="cpu", operations=""): | |||
| # operations is optional to assign a specific backends to each operation. | |||
| # The default value of backends is "cpu". | |||
| if operations: | |||
| session = nnfw_session(nnpackage_path, backends, operations) | |||
| session = onert.session(nnpackage_path, backends, operations) | |||
There was a problem hiding this comment.
Suggested change
| session = onert.session(nnpackage_path, backends, operations) |
Same as previous comment ref: #13468 Could it be removed in this PR along other changes?
infra/nnfw/python/README.md
Outdated
| ``` | ||
|
|
||
| This definition has to be set at the top of the script using nnfw python API. | ||
|
|
||
| ``` | ||
| from nnfwapi.libnnfw_api_pybind import * | ||
| import nnfw_onert |
There was a problem hiding this comment.
Suggested change
| import nnfw_onert | |
| from nnfw_onert import onert |
Wouldn't it be more inline with actual usage? As far as I understand nnfw_onert is just a namespace package, so pointing out to shorter path would be even better, just to use onert.something later on.
|
hseok-oh
force-pushed
the
python_api_update
branch
from
bd5e48f
to
da4f789
Compare
|
@Samsung/one_onert PTAL |
hseok-oh
force-pushed
the
python_api_update
branch
from
da4f789
to
89cb1ba
Compare
- Rename python package: nnfwapi -> onert - Native library install path: "nnfwapi/onert" -> "nnfw_onert/natvie" - Rename binding script: "libnnfw_api_pybind.py" -> "infer.py" - Rename binding session class: "nnfw_session" -> "session" - Update documentation - Update example ONE-DCO-1.0-Signed-off-by: Hyeongseok Oh <[email protected]>
hseok-oh
force-pushed
the
python_api_update
branch
from
89cb1ba
to
0ffee05
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ONE-DCO-1.0-Signed-off-by: Hyeongseok Oh [email protected]