Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[onert] Remove type in Permute IR #13589

Merged
merged 1 commit into from
Aug 8, 2024
Merged

Conversation

hseok-oh
Copy link
Contributor

@hseok-oh hseok-oh commented Aug 5, 2024

This commit removes type in Permute IR.
Permute IR represent copy operation in compilation phase, and can be changed dynamically on execution phase.

ONE-DCO-1.0-Signed-off-by: Hyeongseok Oh [email protected]


Related issue: #12130

@hseok-oh hseok-oh added the PR/ready for review It is ready to review. Please review it. label Aug 5, 2024
@hseok-oh hseok-oh requested a review from a team August 5, 2024 07:10
jyoungyun
jyoungyun previously approved these changes Aug 6, 2024
Copy link
Contributor

@jyoungyun jyoungyun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

ragmani
ragmani previously approved these changes Aug 6, 2024
Copy link
Contributor

@ragmani ragmani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@hseok-oh hseok-oh dismissed stale reviews from ragmani and jyoungyun via ed229d1 August 6, 2024 09:17
ragmani
ragmani previously approved these changes Aug 6, 2024
@jyoungyun
Copy link
Contributor

@hseok-oh Please resolve conflict. Thank you :)

This commit removes type in Permute IR.
Permute IR represent copy operation in compilation phase, and can be changed dynamically on execution phase.

ONE-DCO-1.0-Signed-off-by: Hyeongseok Oh <[email protected]>
Copy link
Contributor

@jyoungyun jyoungyun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@ragmani ragmani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@hseok-oh hseok-oh merged commit 4934752 into Samsung:master Aug 8, 2024
9 checks passed
@hseok-oh hseok-oh deleted the permute_op branch August 8, 2024 09:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
PR/ready for review It is ready to review. Please review it.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants