[onert] Remove Permute IR handling in general backend #13594
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit removes Permute IR handling in acl backends. This IR is handled on builtin backend only because layout changes in backend is not available feature any more. ONE-DCO-1.0-Signed-off-by: Hyeongseok Oh <[email protected]>
hseok-oh
force-pushed
the
remove_permute_backend
branch
from
f8014e9
to
b96d147
Compare
jyoungyun
reviewed
Aug 6, 2024
| const backend::Backend *permute_node_backend = compiler::BackendManager::get().getBuiltin(); | ||
| assert(permute_node_backend->config()->id() == onert::backend::builtin::Config::ID); | ||
| assert(input_backend != backend); |
There was a problem hiding this comment.
(Q) Why should not those backends be the same?
There was a problem hiding this comment.
PermutationInsertionPass was introduced for
- Layout change between use-def
- Backend change between use-def
Now 1) is impossible. So insertPermute is called when backend is changed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit removes Permute IR handling in acl backends.
This IR is handled on builtin backend only because layout changes in backend is not available feature any more.
ONE-DCO-1.0-Signed-off-by: Hyeongseok Oh [email protected]
Related issue: #12130 #13494