-
Notifications
You must be signed in to change notification settings - Fork 158
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[onert] Introduce ExtraTensorIndex #13605
Conversation
767f75f
to
5ec88fb
Compare
When I read
It would be better to use some terms in your explanation above. (ADD) @zetwhite told me that I am not the only one who was curious of the meaning of |
Thansk for comments! I also feel awkward with the name 'Extra'. The name (+) About renaming it, I will do it at once, after both this PR and #13604 are merged. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@zetwhite or who is going to merge this, Please update a typo in commit message. ExtraTensorIndex will be used to |
This PR introduces ExtraTensorIndex. ExtraTensorIndex will be used to identify extra tensor in tensor registry. ONE-DCO-1.0-Signed-off-by: seunghui youn <[email protected]>
75142eb
to
a627086
Compare
Ah, Nice catch. I updated. |
static_assert(sizeof(size_t) >= sizeof(uint32_t), | ||
"ExtraTensorIndex's hash creation error, size_t size is less than uint32_t"); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
(optional) Personally, I prefer to remove this assert.
In general, sizeof(size_t) is 4 on 32-bit system, 8 on 64-bit system. Both cases, it is >= 4 (= sizeof(uint32_t)).
If any, I don't think onert
will support such kind of system.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
This PR introduces ExtraTensorIndex.
ExtraTensorIndex will be used to identify extra tensor in tensor registry.
ONE-DCO-1.0-Signed-off-by: seunghui youn [email protected]
draft : #13486
related : #13282