[tflchef] Introduce finalize_ext_buffer and members #13699
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This will add finalize_ext_buffer method and members to handle data outside of limits of flatbuffres offset. ONE-DCO-1.0-Signed-off-by: SaeHie Park <[email protected]>
shs-park
approved these changes
Aug 19, 2024
| @@ -223,6 +225,11 @@ class ModelChef | |||
| std::vector<flatbuffers::Offset<::tflite::Operator>> _operator_vec; | |||
|
|
|||
| std::string _graph_name; | |||
|
|
|||
| // store Buffer data to external of FB and use (Buffer) offset/size fields | |||
| bool _ext_offset = false; | |||
There was a problem hiding this comment.
There is nowhere to set this flag to true yet, right?
There was a problem hiding this comment.
yup, will be added in another PR.
| align16(result_size); | ||
| result_size += 16; // additional for safety | ||
|
|
||
| std::string result; |
There was a problem hiding this comment.
Just curious, is there any reason to use string instead of vector<uint8_t>?
I was wondering if there might be cases where it is misrecognized as text.
There was a problem hiding this comment.
std::string was referenced from tflite codes
- from
void Translator::AppendBufferData(std::string& result), fromr2.16branch (5bc9d26649cca274750ad3625bd93422617eed4b) - current HEAD is different;
void Translator::AppendBufferData(absl::Cord& result)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This will add finalize_ext_buffer method and members to handle data outside of limits of flatbuffres offset.