-
Notifications
You must be signed in to change notification settings - Fork 158
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[luci/pass] Refactor FuseAddWithTConvPass #13745
[luci/pass] Refactor FuseAddWithTConvPass #13745
Conversation
For: #13685 @seanshpark some of my findings:
|
This commit changes the order of searching for the pattern and adds tests for the pass. ONE-DCO-1.0-Signed-off-by: Jan Iwaszkiewicz <[email protected]>
2aa80ac
to
fdd1efe
Compare
@seanshpark @jinevening PR is ready to review. I cannot add you to reviewers or change the label (is it blocked for contributors?). |
@@ -1,5 +1,5 @@ | |||
/* | |||
* Copyright (c) 2020 Samsung Electronics Co., Ltd. All Rights Reserved | |||
* Copyright (c) 2020-2024 Samsung Electronics Co., Ltd. All Rights Reserved |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we don't need to do this change
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I wasn't sure about it as well... now I have guidance to follow. Will do!
@@ -1,5 +1,5 @@ | |||
/* | |||
* Copyright (c) 2021 Samsung Electronics Co., Ltd. All Rights Reserved | |||
* Copyright (c) 2021-2024 Samsung Electronics Co., Ltd. All Rights Reserved |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ditto
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM thank you!
This commit changes the order of searching for the pattern and adds tests for the pass.
ONE-DCO-1.0-Signed-off-by: Jan Iwaszkiewicz [email protected]