-
Notifications
You must be signed in to change notification settings - Fork 158
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[luci] Remove Add_STR tests #13751
[luci] Remove Add_STR tests #13751
Conversation
This removes invalid Add_STR tests. ONE-DCO-1.0-Signed-off-by: Hyukjin Jeong <[email protected]>
As the comment says
|
PTAL https://github.com/Samsung/ONE/pull/13750/files#r1730675966. STRING inputs are not valid for ADD. Those recipes should have CUSTOM operators. |
I've read the comment but I don't know which test fails. |
Circle files for Add_STR are not created under |
It seems that circle2circle is a problem. |
can you add to to exclude.lst ? |
um.. already added... |
I think tcgenerate is not enough. May need to add |
um... sorry for wrong questions. I was confused with the draft and changes of this PR. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Anyway recipe itself should not be removed for tflchef. |
I see. With #13754, it will be possible to leave the recipes. But, those recipes generate invalid tflite, so I think it would be better to remove them someday. |
Yes, they are invalid files but they exist for test creating STRING tensors, nothing more. |
This removes invalid Add_STR tests.
ONE-DCO-1.0-Signed-off-by: Hyukjin Jeong [email protected]
Related to: https://github.com/Samsung/ONE/pull/13750/files#r1730675966
Draft PR: #13750