Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[res] Fix shape of Net_ZeroDim_001 #13753

Merged
merged 2 commits into from
Aug 26, 2024

Conversation

jinevening
Copy link
Contributor

@jinevening jinevening commented Aug 26, 2024

This adds dynamic shape info to Net_ZeroDim_001.

ONE-DCO-1.0-Signed-off-by: Hyukjin Jeong [email protected]


Related to: #13697
Draft PR: #13750

This adds dynamic shape info to Net_ZeroDim_001.

ONE-DCO-1.0-Signed-off-by: Hyukjin Jeong <[email protected]>
Comment on lines +75 to +84
dim: 0
dim: 8
dim: 0
dim: 64
}
shape_signature {
dim: -1
dim: 8
dim: -1
dim: 64
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is the shape of output. The output shape should match with the new shape inference logic in #13750.

Comment on lines +34 to +38
shape_signature {
dim: 1
dim: -1
dim: 512
}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We may have to revise comment

This was generated by tflchef-reverse from res/TensorFlowTests/NET_0043

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for pointing out. I've updated the comment.

Copy link
Contributor

@seanshpark seanshpark left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM thank you!

@jinevening jinevening merged commit 0d4cf4c into Samsung:master Aug 26, 2024
9 checks passed
@jinevening jinevening deleted the res/fix_net_zerodim_001_shape branch August 26, 2024 09:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants