[luci/service] Support SOFTMAX dynamic shape inference #13784
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This supports dynamic shape inference for SOFTMAX Op. ONE-DCO-1.0-Signed-off-by: Hyukjin Jeong <[email protected]>
seanshpark
reviewed
Aug 27, 2024
Comment on lines
17
to
22
| #include <luci/Service/CircleShapeInference.h> | ||
|
|
||
| #include "CircleCloneNode.h" | ||
|
|
||
| #include "CircleShapeInferenceHelper.h" | ||
|
|
There was a problem hiding this comment.
I've noticed adding includes in #13780 and found that we need some updates
Suggested change
| #include <luci/Service/CircleShapeInference.h> | |
| #include "CircleCloneNode.h" | |
| #include "CircleShapeInferenceHelper.h" | |
| #include "luci/Service/CircleShapeInference.h" | |
| #include "CircleCloneNode.h" | |
| #include "CircleShapeInferenceHelper.h" | |
I couldn't find how the relation of this source and headers was... and now I see.
order of headers;
- direct header for this source file with
"...", should be in same module - in same folder(module) with
"..." - in another module with
<...>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This supports dynamic shape inference for SOFTMAX Op.
ONE-DCO-1.0-Signed-off-by: Hyukjin Jeong [email protected]
Related to: #13697
Draft PR: #13750