Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[luci/service] Add sinf namespace for sinf::Algorithm::visit() #13810

Merged
merged 1 commit into from
Aug 28, 2024
Merged

[luci/service] Add sinf namespace for sinf::Algorithm::visit() #13810

merged 1 commit into from
Aug 28, 2024

Conversation

zetwhite
Copy link
Contributor

@zetwhite zetwhite commented Aug 28, 2024 •
edited
Loading

This PR explicitly marks 'sinf namespace' for each node's sinf::Algorithm::visit() function.

ONE-DCO-1.0-Signed-off-by: seunghui youn [email protected]

@zetwhite
[luci/service] Add sinf namespace for sinf::Algorithm::visit()
f845601 
This PR explicitly marks 'sinf namespace' for each node's sinf::Algorithm::visit() function.

ONE-DCO-1.0-Signed-off-by: seunghui youn <[email protected]>
@zetwhite zetwhite marked this pull request as ready for review August 28, 2024 07:55
jinevening
jinevening approved these changes Aug 28, 2024
View reviewed changes
Copy link
Contributor

@jinevening jinevening left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

seanshpark
seanshpark approved these changes Aug 28, 2024
View reviewed changes
Copy link
Contributor

@seanshpark seanshpark left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM thank you!

shs-park
shs-park approved these changes Aug 28, 2024
View reviewed changes
Copy link
Contributor

@shs-park shs-park left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!
=)

@jinevening jinevening merged commit 6b763ab into Samsung:master Aug 28, 2024
11 checks passed
@seanshpark seanshpark mentioned this pull request Aug 29, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shs-park shs-park shs-park approved these changes

@jinevening jinevening jinevening approved these changes

@seanshpark seanshpark seanshpark approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@zetwhite @seanshpark @jinevening @shs-park