[record-minmax] Revise driver script #13820
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jinevening
reviewed
Aug 29, 2024
| if (arser["--num_threads"]) | ||
| num_threads = arser.get<int>("--num_threads"); | ||
|
|
||
| ::get_values_from<float>(arser, "--min_percentile", 1.0); |
There was a problem hiding this comment.
return value is not used. This will not update variables.
Suggested change
| ::get_values_from<float>(arser, "--min_percentile", 1.0); | |
| float min_percentile = ::get_values_from<float>(arser, "--min_percentile", 1.0); |
If you want to set default value with this function, it would be possible to remove the above default value setting.
jinevening
reviewed
Aug 29, 2024
| if (arser["--num_threads"]) | ||
| num_threads = arser.get<int>("--num_threads"); | ||
|
|
||
| min_percentile = ::get_values_from<float>(arser, "--min_percentile", 1.0); |
There was a problem hiding this comment.
Could you remove the variable declaration code? Default value is repeated.
If you want to keep that code, it would be better to change function signature.
For example, update_arg_if_possible<float>(arser, "--min_percentile", min_percentile) -> update min_percentile if possible, return void
This commit revises driver script for static analysis tool. ONE-DCO-1.0-Signed-off-by: seongwoo <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit revises driver script for static analysis tool.
Related: #13806
ONE-DCO-1.0-Signed-off-by: seongwoo [email protected]