[luci/export] Revise encodeOpBufferByDType for extended Buffer #13878
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This will revise encodeOpBufferByDType for extended Buffer mode. - store buffer content to extra map instead of creating Buffer - return fake Buffer with offset/size of 1 and 1. ONE-DCO-1.0-Signed-off-by: SaeHie Park <[email protected]>
shs-park
approved these changes
Sep 2, 2024
Comment on lines
+372
to
+373
| // create fake indicator buffer | ||
| return circle::CreateBuffer(builder, 0 /* data */, 1 /* offset */, 1 /* size */); |
There was a problem hiding this comment.
What is the purpose of this fake indicator buffer?
Is it used elsewhere? 😅
There was a problem hiding this comment.
real (!fake) Buffer holds actual data,
but this fake Buffer won,t and the offset will point to the file offset to the actual Data.
we initialize two values, offset and size to 1.
then when we produce the file data for export, we update each Buffer offset/size to actual values. so, in import, if we meet the Buffer offset/size as 1, this Buffer is invalid, as there was some problem with the update of actual value.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This will revise encodeOpBufferByDType for extended Buffer mode.