Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[res] Add TFLiteRecipe for dynamic shape pad #14109

Merged
merged 2 commits into from
Sep 27, 2024

Conversation

icodo98
Copy link
Contributor

@icodo98 icodo98 commented Sep 27, 2024

This commit adds TFLiteRecipe for dynamic shape pad.

ONE-DCO-1.0-Signed-off-by: JuYoung Lee [email protected]

This commit adds TFLiteRecipe for dynamic shape pad.

ONE-DCO-1.0-Signed-off-by: JuYoung Lee [email protected]
@icodo98
Copy link
Contributor Author

icodo98 commented Sep 27, 2024

related : #13998
draft : #14050

@icodo98 icodo98 added PR/ready for review It is ready to review. Please review it. SSAFY labels Sep 27, 2024
@icodo98 icodo98 requested review from a team September 27, 2024 00:27
change padding data type to int32

Co-authored-by: SaeHie Park <[email protected]>
Copy link
Contributor

@seanshpark seanshpark left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

operand {
name: "ifm"
type: FLOAT32
shape { dim: 1 dim: 1 dim: 3 dim: 2 }
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just curious,
Is there any special reason to set the second dim to 1?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just curious, Is there any special reason to set the second dim to 1?

There is no particular reason. I just wanted to check if rule-lib.sh works well in dims other than the first one.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just curious, Is there any special reason to set the second dim to 1?

Oh, I misunderstand your question. 😂

I referred this code for shape_signature to test second dim to dynamic.

shape { dim: 1 dim: 3 dim: 3 dim: 2 }
shape_signature { dim: -1 dim: 3 dim: 3 dim: 2 }

Copy link
Contributor

@shs-park shs-park left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!
=)

@seanshpark seanshpark merged commit a1e9884 into Samsung:master Sep 27, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
PR/ready for review It is ready to review. Please review it. SSAFY
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants