Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[luci/svc] Handle 0 in shape for Reshape Op shape inference #14144

Merged
merged 1 commit into from
Oct 2, 2024

Conversation

seanshpark
Copy link
Contributor

This will fix to handle 0 in shape for Reshape Op shape inference.

ONE-DCO-1.0-Signed-off-by: SaeHie Park [email protected]

@seanshpark
Copy link
Contributor Author

@seanshpark seanshpark requested a review from a team October 2, 2024 04:06
Copy link
Contributor

@shs-park shs-park left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I left some questions,
PTAL
=)

compiler/luci/service/src/Nodes/CircleReshape.cpp Outdated Show resolved Hide resolved
compiler/luci/service/src/Nodes/CircleReshape.cpp Outdated Show resolved Hide resolved
@shs-park shs-park requested a review from a team October 2, 2024 04:30
@shs-park
Copy link
Contributor

shs-park commented Oct 2, 2024

I added a reviewer @Samsung/ssafy_2024 for this PR because it seems related to the SSAFY project.
It's not strictly necessary, but if you're interested, you may review it. 😅

This will fix to handle 0 in shape for Reshape Op shape inference.

ONE-DCO-1.0-Signed-off-by: SaeHie Park <[email protected]>
Copy link
Contributor

@shs-park shs-park left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!
=)

@seanshpark seanshpark merged commit 8672617 into Samsung:master Oct 2, 2024
9 checks passed
@seanshpark seanshpark deleted the luci_svc_inf_reshape_0_shape branch October 2, 2024 07:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants