[record-hessian] Introduce HessianComputer #14265
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
seanshpark
requested changes
Oct 28, 2024
|
Commit message looks strange
plz fix. |
seanshpark
reviewed
Oct 28, 2024
seanshpark
reviewed
Oct 28, 2024
seanshpark
reviewed
Oct 28, 2024
seanshpark
reviewed
Oct 28, 2024
seanshpark
reviewed
Oct 28, 2024
seanshpark
reviewed
Oct 28, 2024
seanshpark
reviewed
Oct 28, 2024
seanshpark
reviewed
Oct 28, 2024
seanshpark
reviewed
Oct 28, 2024
seanshpark
reviewed
Oct 28, 2024
seanshpark
reviewed
Oct 28, 2024
seanshpark
reviewed
Oct 28, 2024
seanshpark
reviewed
Oct 28, 2024
seanshpark
reviewed
Oct 28, 2024
| uint32_t dilation_w, uint32_t kernel_oc, uint32_t kernel_h, uint32_t kernel_w, | ||
| uint32_t kernel_ic); | ||
|
|
||
| std::unique_ptr<HessianMap> getMap() const |
There was a problem hiding this comment.
Q) what is the purpose of this method?
There was a problem hiding this comment.
Q) why is the implementation not in .cpp for this method?
There was a problem hiding this comment.
Q) what is the purpose of this method?
Trying to change the hessian values from type(HessianVector) to an STL Vector type.
Reason: HessianVector type only used in this module.
Q) why is the implementation not in
.cppfor this method?
No special reason, we moved it to .cpp.
seanshpark
reviewed
Oct 28, 2024
seanshpark
reviewed
Oct 28, 2024
seanshpark
reviewed
Oct 28, 2024
seanshpark
reviewed
Oct 28, 2024
seanshpark
reviewed
Oct 28, 2024
seanshpark
reviewed
Oct 28, 2024
seanshpark
reviewed
Oct 28, 2024
seanshpark
reviewed
Oct 28, 2024
seanshpark
reviewed
Oct 28, 2024
compiler/record-hessian/include/record-hessian/HessianComputer.h
Outdated
Show resolved
Hide resolved
seanshpark
reviewed
Oct 28, 2024
compiler/record-hessian/include/record-hessian/HessianComputer.h
Outdated
Show resolved
Hide resolved
seanshpark
reviewed
Oct 28, 2024
seanshpark
reviewed
Oct 28, 2024
seanshpark
reviewed
Nov 1, 2024
seanshpark
reviewed
Nov 1, 2024
jinevening
reviewed
Nov 1, 2024
|
LGTM w/ minor comment. #14265 (comment) Please address @seanshpark 's comments. |
This commit introduce gessian computer and hessian vector. ONE-DCO-1.0-Signed-off-by: Banseok Lee <[email protected]>
Fix text formatting by apply formatter. ONE-DCO-1.0-Signed-off-by: Banseok Lee <[email protected]>
Add cmake file, readme file, and requires file. ONE-DCO-1.0-Signed-off-by: Banseok Lee <[email protected]>
Add newline and remove useless comments. ONE-DCO-1.0-Signed-off-by: Banseok Lee <[email protected]>
Add data type check and reuse conv2d. ONE-DCO-1.0-Signed-off-by: Banseok Lee <[email protected]>
Fix formatting and add asserts for. ONE-DCO-1.0-Signed-off-by: Banseok Lee <[email protected]>
Fix formating, add asserts, and move public functions to private. ONE-DCO-1.0-Signed-off-by: Banseok Lee <[email protected]>
Free unfold from the HessianComputer class. ONE-DCO-1.0-Signed-off-by: Banseok Lee <[email protected]>
Fix formating and add asserts make warning message more specific. ONE-DCO-1.0-Signed-off-by: Banseok Lee <[email protected]>
Fix formatting and reorder messages. ONE-DCO-1.0-Signed-off-by: Banseok Lee <[email protected]>
Move getMap from .h file to .cpp file. ONE-DCO-1.0-Signed-off-by: Banseok Lee <[email protected]>
Fix formating, add asserts, and fix all minor bugs. ONE-DCO-1.0-Signed-off-by: Banseok Lee <[email protected]>
Fix formatting and remove test folder. ONE-DCO-1.0-Signed-off-by: Banseok Lee <[email protected]>
Make input_tenser as member of class. ONE-DCO-1.0-Signed-off-by: Banseok Lee <[email protected]>
Change recordhessian logic to make it no use bias. ONE-DCO-1.0-Signed-off-by: Banseok Lee <[email protected]>
Fix formating, bugs, and add asserts. ONE-DCO-1.0-Signed-off-by: Banseok Lee <[email protected]>
Add 2024 license message for test file. ONE-DCO-1.0-Signed-off-by: Banseok Lee <[email protected]>
Reorder include header files to make it looks better. ONE-DCO-1.0-Signed-off-by: Banseok Lee <[email protected]>
Add more detailed explanations and comments, fix code structure. ONE-DCO-1.0-Signed-off-by: Banseok Lee <[email protected]>
Remove long exceeded line, make alias. ONE-DCO-1.0-Signed-off-by: Banseok Lee <[email protected]>
Fix note message & import header files. ONE-DCO-1.0-Signed-off-by: Banseok Lee <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This introduces HessianComputer and HessianVector.
ONE-DCO-1.0-Signed-off-by: Banseok Lee [email protected]
Related Issue : #13480
Draft PR: #13585