[onert/backend] Fix checking indices tensor shape in GatherLayer #14284
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This fixes checking indices tensor shape in GatherLayer. If dimension count is 4 and dim(0) != 0, it should throw exception, but it didn't. ONE-DCO-1.0-Signed-off-by: Seockho Kim [email protected]
glistening
reviewed
Oct 31, 2024
| @@ -83,7 +83,7 @@ void GatherLayer::runByGGMLQuantInputType() | |||
| if (getShape(_input).DimensionsCount() != 2) | |||
| throw std::runtime_error("Gather: block quantized input tensor must be rank 2"); | |||
|
|
|||
| if (getShape(_indices).DimensionsCount() > 4 && | |||
| if (getShape(_indices).DimensionsCount() >= 4 && | |||
There was a problem hiding this comment.
A few days ago, I also thought it was wrong at a glance. However, I think it is true.
It is the negation of the condition in comment.
// Indice: rank < 4 or rank 4 with dim(0) = 1, INT32
not (A or B) = (not A) and (not B)
That is,
not (rank < 4) and not (rank == 4 && dim(0) == 1)
⇔ rank >= 4 && (rank != 4 || dim(0) != 1)
You're right!
(ADD) It would be more readable to use
not ((rank < 4) or (rank == 4 && dim(0) == 1))
zetwhite
approved these changes
Oct 31, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes checking indices tensor shape in GatherLayer.
If dimension count is 4 and dim(0) != 0, it should throw exception, but it didn't.
ONE-DCO-1.0-Signed-off-by: Seockho Kim [email protected]